[Material] RaisedButton text does not default to ColorScheme.onPrimary

[willlarche]

Function getTextColor in ButtonThemeData on the case ButtonTextTheme.normal returns black or white. Material Guidelines expect onPrimary since the fill color is primary.

Details: Make backwards compatible with existing behavior.

[willlarche]

@HansMuller

[Levi-Lesches]

How is this not expected? Doesn't onPrimary mean white or black depending on the Brightness of the primary color?

[willlarche]

onPrimary should be customized to fit in with the other colors in your scheme. Here's how the designer of Shrine did it:

[Levi-Lesches]

Oh OK, seems like I need to take a closer look at Color Schemes again

[Levi-Lesches]

Any progress on this? #38646 needs this to be fixed, since AlertDialogs no longer respect normal theming, and rely solely on ColorSchemes now.

[bitsydarel]

Any update on this ?

[HansMuller]

CC @darrenaustin

[bitsydarel]

is there a way to track the changes made in the framework regarding the colorScheme ?

[HansMuller]

@willlarche, @Levi-Lesches, @bitsydarel - it's been a long time since this issue was opened and I apologize for the lack of activity. If you're still interested in the topic, there's a wide-ranging proposal for updating the button widgets and their themes in #54776. The new proposal does bind the default button colors to the overall theme's ColorSchme, per the Material Design spec.

I'm going to close this issue in favor of #54776.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.