Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded UIViews don't show in scene snapshots #23435

Open
amirh opened this issue Oct 23, 2018 · 3 comments
Open

Embedded UIViews don't show in scene snapshots #23435

amirh opened this issue Oct 23, 2018 · 3 comments
Labels
a: platform-views Embedding Android/iOS views in Flutter apps c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
iOS Platform - platform view review Enable iOS platform view

Comments

@amirh
Copy link
Contributor

amirh commented Oct 23, 2018

No description provided.

@amirh amirh added c: new feature Nothing broken; request for a new capability platform-ios iOS applications specifically a: platform-views Embedding Android/iOS views in Flutter apps labels Oct 23, 2018
amirh referenced this issue in flutter/engine Oct 23, 2018
Plumb the iOS PlatformViewsController into flow.
21ad51a 
For flow to manipulate the embedded UIViews during the paint traversal
it needs some hook in PaintContext.
This PR introduces a ViewEmbeder interface that is implemented by the
iOS PlatformViewsController and plumbs it into PaintContext.

The ViewEmbedder interface is mainly a place holder at this point, as
this PR is focused on just the plumbing.
@zoechi zoechi added the engine flutter/engine repository. See also e: labels. label Dec 11, 2018
@zoechi zoechi added this to the Goals milestone Dec 11, 2018
@zoechi
Copy link
Contributor

zoechi commented Dec 11, 2018

The referenced engine PR was merged.
Was it supposed to fix this issue?

@zoechi zoechi added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Dec 11, 2018
@amirh amirh mentioned this issue Mar 10, 2019
Closed
@iskakaushik iskakaushik self-assigned this Mar 25, 2019
@no-response
Copy link

no-response bot commented Mar 25, 2019

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

@no-response no-response bot closed this as completed Mar 25, 2019
@amirh amirh removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Mar 25, 2019
@amirh
Copy link
Contributor Author

amirh commented Mar 25, 2019

This was not yet implemented

@amirh amirh reopened this Mar 25, 2019
This was referenced Jul 19, 2019
Merged
Open
This was referenced Aug 21, 2019
Closed
Closed
@jmagman jmagman added this to Awaiting triage in iOS Platform - platform view review Feb 25, 2020
@iskakaushik iskakaushik removed their assignment Mar 17, 2020
@ueman ueman mentioned this issue Apr 7, 2020
Closed
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label May 29, 2020
@cyanglaz cyanglaz mentioned this issue Jun 11, 2020
Closed
@Hixie Hixie removed this from the None. milestone Aug 17, 2020
@cyanglaz cyanglaz moved this from To do to Ice Box in Enable iOS platform view Aug 20, 2020
@cyanglaz cyanglaz moved this from Awaiting triage to Engineer reviewed in iOS Platform - platform view review Aug 25, 2021
@flutter-triage-bot flutter-triage-bot bot added team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: platform-views Embedding Android/iOS views in Flutter apps c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
Enable iOS platform view
  
Ice Box
iOS Platform - platform view review
  
Engineer reviewed
Milestone
No milestone
Development

No branches or pull requests
6 participants
@zoechi @Hixie @iskakaushik @amirh @kf6gpe @TahaTesser