request getters for _drawerOpened and _endDrawerOpened in Scaffold

[morphiak]

So I have a use case for knowing when a drawer is open, and there are private scaffold variables that do what I need, seems a no brainer to add

  bool isDrawerOpen(){
    return _drawerOpened;
  }
  bool isEndDrawerOpen(){
    return _endDrawerOpened;
  }

or getters or whatever format is preferred.
Seems like it should be harmless and add value, but maintainer knows best.
Please consider.

[zoechi]

Using a custom DrawerController should allow you to do that.
See for example #21272 (comment)

[morphiak]

Thanks for that, (I also bookmarked https://flutter.io/support/)

When I put

  bool drawerOpen;

  void setDrawerOpened(bool isOpen) {
    drawerOpen = isOpen;
  }

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
      drawer: DrawerController(
          child: Drawer(
            child: Text("SS"),
          ),
          drawerCallback: setDrawerOpened,
          alignment: DrawerAlignment.start),

I get the same undesired tint screen, then drawer behavior as described above, hitting setDrawerOpen on the second swipe. (perhaps there are now two DrawerControllers?)
After a quick look at the scaffold.dart usage (line 1458), I tried

    return new Scaffold(
//      drawer: 
      appBar: new AppBar(
        title: new Text(widget.title),
      ),
      body: DrawerController(
          child: Drawer(
            child: Text("SS"),
          ),
          drawerCallback: setDrawerOpened,
          alignment: DrawerAlignment.start),

which has the expected drawer behavior, and hits the callback,but you can't put anything on the screen :(
Put it inside a column widget and the drawer doesn't work.
Unless I'm missing some pattern for adding controllers to widget trees, this seems broken to me.
The normal pattern would be to have the controller as a named parameter to Drawer would it not ? Not to mention simple and intuitive (as too are getters ;).

[zoechi]

Sorry to hear.
I'm merging with #21272 then.
Make sure you upvote to raise it's priority.

[rhymelph]

Hi,I want to you can try this.

  bool drawerOpen;

  void setDrawerOpened(bool isOpen) {
    drawerOpen = isOpen;
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      drawer: new DrawerWidget(
        callback: setDrawerOpened,
      ),
    );
  }


class DrawerWidget extends StatefulWidget {
  DrawerCallback callback;

  DrawerWidget({this.callback});

  @override
  _DrawerWidgetState createState() => _DrawerWidgetState();
}


class _DrawerWidgetState extends State<DrawerWidget> {

  @override
  void initState() {
    widget.callback(true);
    super.initState();
  }

  @override
  void dispose() {
    widget.callback(false);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Drawer(
      child: Text("SS"),
    );
  }
}

[morphiak]

For those googling in, there's now (v0.11.3) getters for isDrawerOpen and isEndDrawerOpen in scaffold.dart.
Thank you kindly :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.