Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename classes/methods #23705

Closed
sfshaza2 opened this issue Oct 29, 2018 · 4 comments
Closed

Rename classes/methods #23705

sfshaza2 opened this issue Oct 29, 2018 · 4 comments
Labels
c: API break Backwards-incompatible API changes found in release: 1.21 Found to occur in 1.21 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version

Comments

@sfshaza2
Copy link
Contributor

We have been asked to remove instances of "Blacklist" and "Whitelist" from the docs. I searched the API docs and found two classes:

https://docs.flutter.io/flutter/services/WhitelistingTextInputFormatter-class.html
https://docs.flutter.io/flutter/services/BlacklistingTextInputFormatter-class.html

And methods belonging to these classes. Please reconsider renaming.

Suggested replacements:
denylist/allowlist or blocklist/allowlist

Basically, use what makes sense for the domain.
@sfshaza2 sfshaza2 added the d: api docs Issues with https://api.flutter.dev/ label Oct 29, 2018
@zoechi zoechi added the framework flutter/packages/flutter repository. See also f: labels. label Dec 11, 2018
@zoechi zoechi added this to the Goals milestone Dec 11, 2018
@goderbauer goderbauer added the c: API break Backwards-incompatible API changes label Jan 4, 2019
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label May 29, 2020
@miquelbeltran
Copy link
Member

Seems that the fix is coming here: #59120 🎉

@iapicca
Copy link
Contributor

iapicca commented Jul 24, 2020

Hi @sfshaza2
despite the PR being merge I see in the latest master the classes containing the terms indicated

logs 
[✓] Flutter (Channel master, 1.21.0-6.0.pre.17, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.21.0-6.0.pre.17 at /Users/nevercode/development/flutter_master
    • Framework revision e64fe11542 (12 hours ago), 2020-07-23 18:11:17 -0700
    • Engine revision 626244a72c
    • Dart version 2.9.0 (build 2.9.0-21.0.dev a3815b6590)


[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 84.0.4147.89

• No issues found!
Thank you

@iapicca iapicca added found in release: 1.21 Found to occur in 1.21 has reproducible steps The issue has been confirmed reproducible and is ready to work on and removed d: api docs Issues with https://api.flutter.dev/ labels Jul 24, 2020
@Hixie Hixie removed this from the None. milestone Aug 17, 2020
@darshankawar
Copy link
Member

This seems to be fixed per as verified on latest master version.
Closing as such.

@darshankawar darshankawar added the r: fixed Issue is closed as already fixed in a newer version label Oct 20, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: API break Backwards-incompatible API changes found in release: 1.21 Found to occur in 1.21 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@zoechi @Hixie @goderbauer @kf6gpe @miquelbeltran @sfshaza2 @iapicca @darshankawar