Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the snippets on AppBar class doc #24885

Closed
jayoung-lee opened this issue Nov 30, 2018 · 1 comment · Fixed by #32530
Closed

Improving the snippets on AppBar class doc #24885

jayoung-lee opened this issue Nov 30, 2018 · 1 comment · Fixed by #32530
Assignees
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@jayoung-lee
Copy link
Contributor

jayoung-lee commented Nov 30, 2018

AppBar/actions doc on master docs has 'Sample in an App' tab, but the current example is not really complete.

The 'actions' keyword imply interactivity, but because its onPressed: (){} property is empty, at least 3 participants in the recent user study spent long time searching for its example, even though they had this snippet in hand.

Can we make it extend StatefulWidget like the one in IconButton class and have an actual action associated with it?

This complete app can be added to the AppBar class as well, which is currently empty!

Cc: @galeyang, @gspencergoog @InMatrix

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ labels Dec 2, 2018
@zoechi zoechi added this to the Goals milestone Dec 2, 2018
@shihaohong shihaohong self-assigned this May 10, 2019
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants