Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter doctor should report whether the Flutter install dir is clean #25220

Open
zoechi opened this issue Dec 11, 2018 · 6 comments
Open

flutter doctor should report whether the Flutter install dir is clean #25220

zoechi opened this issue Dec 11, 2018 · 6 comments
Labels
c: new feature Nothing broken; request for a new capability P2 Important issues not at the top of the work list t: flutter doctor Problem related to the "flutter doctor" tool team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@zoechi
Copy link
Contributor

zoechi commented Dec 11, 2018

If the Flutter install directory contains any changes flutter doctor or flutter doctor -v should report that.

It would make it easier for support questions that are caused by inadvertently modified files in the Flutter install dir.

I created https://github.com/flutter/flutter/wiki/Workarounds-for-common-issues#flutter-installation-corrupted because this happens quite a lot.

See also #9218
I'd suggest to do the git clean -xfd git stash drop, ... when --force (flutter upgrade --force, flutter channel foo --force) is passed.
It might be useful to execute the git clean stuff with flutter upgrade --force even when no upgrade is available.

@zoechi zoechi added tool Affects the "flutter" command-line tool. See also t: labels. t: flutter doctor Problem related to the "flutter doctor" tool labels Dec 11, 2018
@zoechi zoechi changed the title flutter doctor should report if the Flutter install dir is clean flutter doctor should report whether the Flutter install dir is clean Dec 11, 2018
@zoechi zoechi added this to the Goals milestone Dec 11, 2018
@zoechi zoechi added c: new feature Nothing broken; request for a new capability tool Affects the "flutter" command-line tool. See also t: labels. t: flutter doctor Problem related to the "flutter doctor" tool and removed t: flutter doctor Problem related to the "flutter doctor" tool tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 11, 2018
@zoechi
Copy link
Contributor Author

zoechi commented Jan 8, 2019

@kangwang1988
Copy link
Contributor

Just git operation might not be enough. As some developers may have their own fork/branch, modifications.
It would be better to check based on some table/record staff, similar to #26069

@zoechi
Copy link
Contributor Author

zoechi commented Jan 14, 2019

Somewhat related #14120, #18532

@zoechi
Copy link
Contributor Author

zoechi commented Jan 24, 2019

Related #1963

@jmagman
Copy link
Member

jmagman commented Nov 12, 2019

@christopherfujino We were discussing this recently.

git diff --exit-code --quiet
git status --porcelain
or some combo thereof.

@jmagman jmagman added this to Awaiting triage in Tools - doctor review Jan 10, 2020
@christopherfujino christopherfujino moved this from Awaiting triage to Engineer reviewed in Tools - doctor review Feb 4, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label May 29, 2020
@Hixie Hixie removed this from the None. milestone Aug 17, 2020
@flutter-triage-bot flutter-triage-bot bot added team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team labels Jul 8, 2023
@Afek-Sakaju
Copy link

If the Flutter install directory contains any changes flutter doctor or flutter doctor -v should report that.

It would make it easier for support questions that are caused by inadvertently modified files in the Flutter install dir.

I created https://github.com/flutter/flutter/wiki/Workarounds-for-common-issues#flutter-installation-corrupted because this happens quite a lot.

See also #9218 I'd suggest to do the git clean -xfd git stash drop, ... when --force (flutter upgrade --force, flutter channel foo --force) is passed. It might be useful to execute the git clean stuff with flutter upgrade --force even when no upgrade is available.

really helpful! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: new feature Nothing broken; request for a new capability P2 Important issues not at the top of the work list t: flutter doctor Problem related to the "flutter doctor" tool team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
Tools - doctor review
  
Engineer reviewed
Development

No branches or pull requests

6 participants