Cannot apply theme for text of button using ButtonThemeData

[trietbui85]

I want to use ButtonThemeData for not only for button theme but also for text theme (which is the child of that button). However I notice it only take effect on button, but not text.

Steps to Reproduce

1. Here is source code

return MaterialApp(
      title: 'FileString demo',
      theme: ThemeData(
          primaryColor: Color(0xff2B5A95),
          buttonTheme: ButtonThemeData(
            buttonColor: Color(0xff9DCB3B),
            textTheme: ButtonTextTheme.primary,
          )),

2. After reading source code of ButtonThemeData, I see we're allowed to theme text to some predefined colors such as ButtonTextTheme.primary, normal or accent. However I myself want to control its style (text color, text size) instead. Is it possible?

Logs

[√] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version 6.1.7601], locale en-US)
    • Flutter version 1.2.1 at C:\DevTools\flutter
    • Framework revision 8661d8aecd (5 weeks ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\DevTools\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = C:\DevTools\Android\sdk
    • Java binary at: C:\DevTools\Android\studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.3)
    • Android Studio at C:\DevTools\Android\studio
    • Flutter plugin version 33.4.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[!] IntelliJ IDEA Community Edition (version 2018.2)
    • IntelliJ at C:\Users\TrietBui\AppData\Local\JetBrains\Toolbox\apps\IDEA-C\ch-0\182.4892.20
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[√] Connected device (1 available)
    • SM G960F • 1ca85fd0cb0c7ece • android-arm64 • Android 9 (API 28)

[esarbanis]

For a RaisedButton you can only get Colors.white or Colors.black depending on the brightness of the fill color. Check out getTextColor method.

The only way I see to override it is from the RaisedButton.textColor property.

A workaround could be to introduce a common widget for the button and use that throughout your application.

[HansMuller]

@anticafe, @esarbanis, @duzenko it's been a long time since issue was opened and I apologize for the lack of activity. If you're still interested in the topic, there's a wide-ranging proposal for updating the button widgets and their themes in #54776. The new proposal does bind the default button colors to the overall theme's ColorSchme, per the Material Design spec. It also addresses the difficult of defining the default button text color.

I'm going to close this issue in favor of #54776.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.