Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter/flutter Cirrus should run flutter/plugins tests #30446

Closed
collinjackson opened this issue Apr 3, 2019 · 7 comments
Closed

flutter/flutter Cirrus should run flutter/plugins tests #30446

collinjackson opened this issue Apr 3, 2019 · 7 comments
Assignees
Labels
c: new feature Nothing broken; request for a new capability P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@collinjackson
Copy link
Contributor

Opening this issue to track progress on this desired infra feature that will help identify Flutter changes that break plugins.

@collinjackson collinjackson added c: new feature Nothing broken; request for a new capability team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin labels Apr 3, 2019
@collinjackson collinjackson self-assigned this Aug 28, 2019
@mklim
Copy link
Contributor

mklim commented Oct 23, 2019

Talked about this a little with @Hixie offline. There's some blockers to getting our whole suite up and running but an immediate low hanging fruit would be to just add our analyzer warnings and potentially unit tests to flutter/tests. It won't prevent plugins from being truly broken by framework changes but it would be trivial to add and would prevent a lot of surprising breakages based on things like a new const constructor.

@mklim mklim self-assigned this Oct 23, 2019
@mklim mklim removed their assignment Feb 7, 2020
@stuartmorgan stuartmorgan added the P2 Important issues not at the top of the work list label May 27, 2021
@stuartmorgan
Copy link
Contributor

@Hixie Can you summarize the blockers here? This would be an alternative to going to a roller for Flutter in flutter/plugins.

@Hixie
Copy link
Contributor

Hixie commented May 27, 2021

I don't think there's any blockers at this point, we just need to do it. We should add a shard to flutter/flutter that checks out the right version of flutter/plugins (I'd use find_commit.dart, but you can use a pin if you prefer, so long as we have an autoroller — let's not add yet more manual rolls) and runs the tests.

@Hixie
Copy link
Contributor

Hixie commented May 27, 2021

(I'd probably do this on LUCI, not Cirrus.)

@stuartmorgan
Copy link
Contributor

We already have the autoroller with a pinned version for the existing analyze-flutter/plugins-in-flutter/flutter test, so we could bootstrap on that.

@godofredoc Anything you can think of that would prevent us from adding this now?

@stuartmorgan
Copy link
Contributor

I'm going to close this in favor of #93811 for solving the remaining out-of-band failures. We're already running analyzer tests in flutter/flutter, and I think doing more than that is probably diminishing returns; running all tests would be problematic for various reasons (duplication of CI resources, maintenance, exacerbation of flake in flutter/flutter, etc.).

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: new feature Nothing broken; request for a new capability P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants