Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mouse button support to GLFW shell #33220

Open
stuartmorgan opened this issue May 22, 2019 · 5 comments
Open

Add mouse button support to GLFW shell #33220

stuartmorgan opened this issue May 22, 2019 · 5 comments
Labels
a: desktop Running on desktop e: glfw GLFW desktop embedding engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-linux Owned by the Linux platform team triaged-linux Triaged by the Linux platform team

Comments

@stuartmorgan
Copy link
Contributor

The embedding API now has the ability to pass mouse buttons through, enabling right click, middle click, etc. It's been wired up in the macOS shell, but still needs to be done for the GLFW shell.
@stuartmorgan stuartmorgan added platform-windows Building on or for Windows specifically platform-linux Building on or for Linux specifically e: desktop labels May 22, 2019
@stuartmorgan stuartmorgan mentioned this issue Jun 10, 2019
Closed
@stuartmorgan stuartmorgan added engine flutter/engine repository. See also e: labels. a: desktop Running on desktop and removed e: desktop labels Jul 26, 2019
@stuartmorgan stuartmorgan added the e: glfw GLFW desktop embedding label Aug 8, 2019
@stuartmorgan stuartmorgan added this to the No milestone necessary milestone Aug 13, 2019
@stuartmorgan stuartmorgan removed platform-windows Building on or for Windows specifically platform-linux Building on or for Linux specifically labels Aug 15, 2019
@stuartmorgan stuartmorgan mentioned this issue Sep 8, 2019
Closed
@Quijx
Copy link

Quijx commented Jan 9, 2020

@stuartmorgan Any news on when this will be done? Middle click and especially right click are essential functionalities for almost all desktop applications, and considering that many developers prefer working on Linux, I think that this problem should be tackled soon.

@stuartmorgan
Copy link
Contributor Author

Improvements to the temporary GLFW implementation are not currently a priority, so there's no specific timeline. I'm happy to review a PR from someone interesting in implementing this.

@stuartmorgan stuartmorgan mentioned this issue May 11, 2020
Closed
@kf6gpe kf6gpe added the P6 label May 29, 2020
@Quijx
Copy link

Quijx commented Jul 13, 2020

@stuartmorgan Can't this issue be closed, since the GLFW shell was replaced with GTK?

@stuartmorgan
Copy link
Contributor Author

The GLFW embedding still exists, it's just not used by tooling.

@Hixie Hixie removed this from the No specific schedule milestone Dec 10, 2020
@flutter-triage-bot flutter-triage-bot bot added P3 Issues that are less important to the Flutter project and removed P6 labels Jun 28, 2023
@cbracken cbracken added fyi-macos For the attention of macOS platform team fyi-windows For the attention of the Windows platform team team-linux Owned by the Linux platform team labels Jun 7, 2024
@flutter-triage-bot
Copy link

The triaged-desktop label is irrelevant if there is no team-desktop label or fyi-desktop label.

@cbracken cbracken added the triaged-linux Triaged by the Linux platform team label Jun 7, 2024
@LouiseHsu LouiseHsu added the triaged-macos Triaged by the macOS platform team label Jun 18, 2024
@flutter-triage-bot flutter-triage-bot bot removed fyi-macos For the attention of macOS platform team triaged-macos Triaged by the macOS platform team labels Jun 18, 2024
@loic-sharma loic-sharma removed the fyi-windows For the attention of the Windows platform team label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: desktop Running on desktop e: glfw GLFW desktop embedding engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-linux Owned by the Linux platform team triaged-linux Triaged by the Linux platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@stuartmorgan @cbracken @Hixie @loic-sharma @kf6gpe @LouiseHsu @Quijx @darshankawar