Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter trace --stop no longer works on Android #3335

Closed
eseidelGoogle opened this issue Apr 14, 2016 · 3 comments
Closed

flutter trace --stop no longer works on Android #3335

eseidelGoogle opened this issue Apr 14, 2016 · 3 comments
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@eseidelGoogle
Copy link
Contributor

Broke as of flutter/engine@09972ad

I haven't tested on iOS, may be broken there too.
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/android_device.dart#L385
is the line with the bad assumption in flutter trace --stop

I suspect we should update it to pull the trace over observatory instead of via a test file? @johnmccutchan or @chinmaygarde would know?

FYI @jason-simmons

@eseidelGoogle eseidelGoogle added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 14, 2016
@eseidelGoogle
Copy link
Contributor Author

I ran into this while trying to use https://github.com/flutter/flutter/blob/master/dev/profile_startup.dart

@jason-simmons
Copy link
Member

This should be fixed now

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

No branches or pull requests

2 participants