You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now some of our first-party plugins tests use mockito to mock out MethodChannel and others use dependencies on mockito and some use setMockMethodCallHandler.
This results in contributors writing more tests in a deprecated test style (see flutter/plugins#1067) because they're adding to existing test suites or copying test code from other first-party plugins.
Here are the steps to remove dependencies on mockito:
Update contribution guide with a note that the plugins team prefers tests written using setMockMethodCallHandler instead of mockito and may ask tests using mockito to be rewritten.
Update firebase_analytics tests
Update battery tests
Update firebase_messaging tests
Update share plugin tests
Remove mockito pubspec dependency from firebase_admob
Remove mockito pubspec dependency from firebase_database
The text was updated successfully, but these errors were encountered:
collinjackson
changed the title
Remove mockito from first-party plugins unit tests
Remove mockito MethodChannel mocks from first-party plugins unit tests
Jun 11, 2019
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Right now some of our first-party plugins tests use mockito to mock out MethodChannel and others use dependencies on mockito and some use
setMockMethodCallHandler
.This results in contributors writing more tests in a deprecated test style (see flutter/plugins#1067) because they're adding to existing test suites or copying test code from other first-party plugins.
Here are the steps to remove dependencies on mockito:
setMockMethodCallHandler
instead of mockito and may ask tests using mockito to be rewritten.The text was updated successfully, but these errors were encountered: