Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webview_flutter Unable to create JsDialog without an Activity #41186

Closed
bineanzhou opened this issue Sep 24, 2019 · 6 comments
Closed

webview_flutter Unable to create JsDialog without an Activity #41186

bineanzhou opened this issue Sep 24, 2019 · 6 comments
Labels
p: webview The WebView plugin package flutter/packages repository. See also p: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Comments

@bineanzhou
Copy link

public final class WebViewFactory extends PlatformViewFactory {
  private final BinaryMessenger messenger;
  private final View containerView;

  WebViewFactory(BinaryMessenger messenger, View containerView) {
    super(StandardMessageCodec.INSTANCE);
    this.messenger = messenger;
    this.containerView = containerView;
  }

  @SuppressWarnings("unchecked")
  @Override
  public PlatformView create(Context context, int id, Object args) {
    Map<String, Object> params = (Map<String, Object>) args;
//    return new FlutterWebView(context, messenger, id, params, containerView);
    return new FlutterWebView(containerView.getContext(), messenger, id, params, containerView);
  }
}
@BondarenkoStas
Copy link

@bineanzhou Please provide your flutter doctor -v output and webview_flutter version.
May be connected to #34853.

@BondarenkoStas BondarenkoStas added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 24, 2019
@bineanzhou
Copy link
Author

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 25, 2019
@bineanzhou
Copy link
Author

@bineanzhou Please provide your flutter doctor -v output and webview_flutter version.
May be connected to #34853.

my ext
https://github.com/bineanzhou/webview_flutter_ext

@BondarenkoStas BondarenkoStas added p: webview The WebView plugin plugin labels Sep 25, 2019
@TahaTesser
Copy link
Member

TahaTesser commented Mar 6, 2020

Hi @bineanzhou
if you're still experiencing this issue
To better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem

Thank you

@TahaTesser TahaTesser added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Mar 6, 2020
@TahaTesser
Copy link
Member

Hi @bineanzhou
Without additional information, we are unfortunately not sure how to resolve this issue. We are
therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the
bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

@lock
Copy link

lock bot commented May 6, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock bot locked and limited conversation to collaborators May 6, 2020
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: webview The WebView plugin package flutter/packages repository. See also p: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds
Projects
None yet
Development

No branches or pull requests

3 participants