Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB] Need more PageTransitionTheme for web transition #41564

Open
kwak914 opened this issue Sep 29, 2019 · 3 comments
Open

[WEB] Need more PageTransitionTheme for web transition #41564

kwak914 opened this issue Sep 29, 2019 · 3 comments
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@kwak914
Copy link

kwak914 commented Sep 29, 2019

Use case

Proposal

    pageTransitionsTheme: PageTransitionsTheme(builders: {
      TargetPlatform.iOS: CupertinoPageTransitionsBuilder(),
      TargetPlatform.android: OpenUpwardsPageTransitionsBuilder(),
    }),

Web transition doesn't need those of
-FadeUpwardsPageTransitionsBuilder
-OpenUpwardsPageTransitionsBuilder
-CupertinoPageTransitionsBuilder

I think TranisitionBuilder for web should be supported,

such as NoAnimationTransitionBuilder..

@kwak914 kwak914 changed the title Need more pagetransitionTheme [WEB] Need more PageTransitionTheme for web transition Sep 29, 2019
@escamoteur escamoteur added framework flutter/packages/flutter repository. See also f: labels. c: proposal A detailed proposal for a change to Flutter c: new feature Nothing broken; request for a new capability platform-web Web applications specifically labels Sep 29, 2019
@yjbanov
Copy link
Contributor

yjbanov commented Oct 10, 2019

This looks like a design language question. It also applies to desktop platforms. I'm removing platform-web tag.

@yjbanov
Copy link
Contributor

yjbanov commented Oct 10, 2019

/cc @HansMuller

@yjbanov yjbanov removed the platform-web Web applications specifically label Oct 10, 2019
@braj065
Copy link

braj065 commented Oct 11, 2021

When using Nav 2.0 to achieve a custom transition i am using PageRouteBuilder(transitionBuilder:). But the 'transitionBuilder' isn't accepting 'DualTransitionBuilder' to achieve smoother screen enter/exit animation. So i am adding the custom animation using 'DualTransitionBuilder' in ThemeData 'pageTransitionsTheme'. But there is no TargetPlatform.Web for 'pageTransitionsTheme'. So not able to achieve 'DualTransitionBuilder' in web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
5 participants