Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cupertino tests and enable them on CI in Web mode #41920

Closed
yjbanov opened this issue Oct 3, 2019 · 2 comments
Closed

Fix cupertino tests and enable them on CI in Web mode #41920

yjbanov opened this issue Oct 3, 2019 · 2 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team: skip-test An issue used to track tests that are skipped. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
Flutter for web test coverage

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Oct 3, 2019

We currently skip all packages/flutter/test/cupertino tests on CI because they fail. We should fix them.
@yjbanov yjbanov added a: tests "flutter test", flutter_test, or one of our tests platform-web Web applications specifically labels Oct 3, 2019
@yjbanov yjbanov added this to the Near-term Goals milestone Oct 3, 2019
@yjbanov yjbanov added this to To do in Flutter for web test coverage via automation Oct 3, 2019
@yjbanov yjbanov moved this from To do to In progress in Flutter for web test coverage Oct 25, 2019
@yjbanov yjbanov self-assigned this Oct 25, 2019
This was referenced Oct 25, 2019
Merged
Merged
@yjbanov yjbanov modified the milestones: Near-term Goals, January 2020 Dec 18, 2019
@yjbanov yjbanov modified the milestones: January 2020, February 2020 Feb 4, 2020
@Hixie Hixie modified the milestones: February 2020, Overdue Mar 3, 2020
@yjbanov yjbanov modified the milestones: Overdue, March 2020 Mar 3, 2020
@yjbanov yjbanov removed their assignment Mar 24, 2020
@yjbanov yjbanov modified the milestones: March 2020, Near-term Goals Mar 24, 2020
@kf6gpe kf6gpe added the P1 High-priority issues at the top of the work list label May 29, 2020
@kf6gpe kf6gpe modified the milestone: Near-term Goals Jun 1, 2020
@yjbanov yjbanov added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Jun 17, 2020
@iapicca iapicca added the framework flutter/packages/flutter repository. See also f: labels. label Jul 3, 2020
@kf6gpe kf6gpe modified the milestone: [DEPRECATED] Near-term Goals Jul 7, 2020
@kf6gpe kf6gpe removed this from the [DEPRECATED] Near-term Goals milestone Jul 22, 2020
@yjbanov yjbanov moved this from In progress to To do in Flutter for web test coverage Aug 13, 2020
@Hixie Hixie removed this from the None milestone Aug 17, 2020
@darrenaustin darrenaustin added team: skip-test An issue used to track tests that are skipped. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. c: tech-debt Technical debt, code quality, testing, etc. labels Aug 2, 2021
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-web Owned by Web platform team triaged-web Triaged by Web platform team labels Jul 8, 2023
@yjbanov
Copy link
Contributor Author

yjbanov commented Dec 20, 2023

This is no longer true. We still have some hand-picked Cupertino tests we skip, but we certainly do not skip them all.

@yjbanov yjbanov closed this as completed Dec 20, 2023
Flutter for web test coverage automation moved this from To do to Done Dec 20, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team: skip-test An issue used to track tests that are skipped. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
Flutter for web test coverage
  
Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@darrenaustin @yjbanov @Hixie @kf6gpe @iapicca @pedromassangocode