RadioListTile Theme Property for selected #42621
Comments
janmoppel
added
the
framework
|
Hello @workerbee22 ! Thank you for posting an issue. |
janmoppel
added
the
waiting for customer response
|
no-response
bot
removed
the
waiting for customer response
HansMuller
added
the
f: material design
The doc surely mentions that the
Going through the source code, the The issue has reproducibile steps here. SS
|
|
@shihaohong I would like to work on this issue, can we make the |
|
Based on the name of the properties, I would imagine that @HansMuller might know more about the history of the different color parameters and which one we should really default to or if we should just keep it as-is and update the API docs. |
|
@shihaohong Sure, till then I'll go through the breaking change policy. |
|
@shihaohong I went through the breaking change policy, and I agree, we can change the |
|
@shihaohong should I create a design document for proposing the change, or wait for the take from @HansMuller on the solution? |
|
Sorry about the delay, I'll review this today! |
|
I'm going to assign Hans for now just so that there is a reminder for him to provide some feedback when his week starts |
|
@shihaohong OK, that worked :-). This issue depends on the theme's accent color, which is becoming obsolete: https://docs.google.com/document/d/1kzIOQN4QYfVsc5lMZgy_A-FWGXBAJBMySGqZqsJytcE/edit#heading=h.2hl3s1i2nq6o RadioButton and RadioListTile currently do not conform to the patterns described in the "Theme System Updates" document - flutter.dev/go/material-theme-system-updates. Migrating them will require breaking changes, as Shi Hao pointed out, and will likely require us to update test repo and internal applications. So although this fixing this issue might seem straightforward on the surface, it's likely to be difficult. |
|
From Hans' outline, it seems like it will be a multi-step breaking change that would also require a Googler to fix issues that surface in internal applications. That being said, I see two options:
|
|
I know since this won't priority but if the team decides to go with the first option in the future, I'll be more than happy to contribute if any external contribution required :) |
|
Reproducible on the latest master flutter doctor -v |
markusaksli-nc
added
found in release: 1.21
|
Hi @workerbee22
Also, when using Demo
Sample codeimport 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({Key? key}) : super(key: key);
static const String _title = 'Flutter Application';
@override
Widget build(BuildContext context) {
return MaterialApp(
title: _title,
theme: ThemeData(
accentColor: Colors.red,
toggleableActiveColor: Colors.green,
colorScheme: const ColorScheme.light(secondary: Colors.yellow),
),
home: Scaffold(
appBar: AppBar(title: const Text(_title)),
body: const MyStatefulWidget(),
),
);
}
}
/// stateful widget that the main application instantiates
class MyStatefulWidget extends StatefulWidget {
const MyStatefulWidget({Key? key}) : super(key: key);
@override
State<MyStatefulWidget> createState() => _MyStatefulWidgetState();
}
enum Fruit { apple, banana }
/// private State class that goes with MyStatefulWidget
class _MyStatefulWidgetState extends State<MyStatefulWidget> {
Fruit? _fruit = Fruit.apple;
@override
Widget build(BuildContext context) {
return Center(
child: Column(
children: <Widget>[
RadioListTile<Fruit>(
// activeColor: Colors.red,
controlAffinity: ListTileControlAffinity.trailing,
title: const Text('Apple'),
value: Fruit.apple,
groupValue: _fruit,
onChanged: (Fruit? value) {
setState(() {
_fruit = value;
});
},
),
RadioListTile<Fruit>(
// activeColor: Colors.red,
title: const Text('Banana'),
value: Fruit.banana,
groupValue: _fruit,
onChanged: (Fruit? value) {
setState(() {
_fruit = value;
});
},
),
],
),
);
}
}
flutter doctor -v (stable and master)[✓] Flutter (Channel stable, 3.3.7, on macOS 13.0 22A380 darwin-x64, locale en-VN)
• Flutter version 3.3.7 on channel stable at /Users/huynq/Documents/GitHub/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision e99c9c7cd9 (27 hours ago), 2022-11-01 16:59:00 -0700
• Engine revision 857bd6b74c
• Dart version 2.18.4
• DevTools version 2.15.0
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/huynq/Library/Android/sdk
• Platform android-33, build-tools 31.0.0
• ANDROID_HOME = /Users/huynq/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
• Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
• Build 14A400
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 70.0.5
• Dart plugin version 222.4167.21
[✓] VS Code (version 1.72.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.50.0
[✓] Connected device (3 available)
• SM T225 (mobile) • R9JT3004VRJ • android-arm64 • Android 12 (API 31)
• macOS (desktop) • macos • darwin-x64 • macOS 13.0 22A380 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 107.0.5304.87
[✓] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!
[!] Flutter (Channel master, 3.5.0-12.0.pre.93, on macOS 13.0 22A380 darwin-x64, locale en-VN)
• Flutter version 3.5.0-12.0.pre.93 on channel master at /Users/huynq/Documents/GitHub/flutter_master
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 92a66683a1 (6 hours ago), 2022-11-02 16:50:38 -0400
• Engine revision 840a7b3462
• Dart version 2.19.0 (build 2.19.0-364.0.dev)
• DevTools version 2.19.0
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/huynq/Library/Android/sdk
• Platform android-33, build-tools 31.0.0
• ANDROID_HOME = /Users/huynq/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
• Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
• Build 14A400
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 70.0.5
• Dart plugin version 222.4167.21
[✓] VS Code (version 1.72.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.50.0
[✓] Connected device (3 available)
• SM T225 (mobile) • R9JT3004VRJ • android-arm64 • Android 12 (API 31)
• macOS (desktop) • macos • darwin-x64 • macOS 13.0 22A380 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 107.0.5304.87
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.
Please retry and confirm again. Thanks! |
huycozy
added
the
waiting for customer response
|
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
When using RadioListTile it uses a radio Button. But activeColor property doc for this widget says uses the Theme accentColor property by default. Which I think is true.
But if you use controlAffinity property of RadioListTile to put radio button to right side, then the color of the selected item in the list follows the RadioButton activeColor property which defaults to the theme toggleableActiveColor property.
Expected behaviour, both widgets RadioListTile and RadioButton to use the same consistent theme property when no color is provided.
The text was updated successfully, but these errors were encountered: