Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WeakPtr::getUnsafe() #42949

Open
gw280 opened this issue Oct 17, 2019 · 0 comments
Open

Remove WeakPtr::getUnsafe() #42949

gw280 opened this issue Oct 17, 2019 · 0 comments
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@gw280
Copy link
Contributor

gw280 commented Oct 17, 2019

getUnsafe() is used as a stopgap measure to allow us to turn on thread safety checks again for most WeakPtr usages.

These are the issues that need fixing to remove getUnsafe():

#42946
#42947
#42948
@chinmaygarde chinmaygarde added the engine flutter/engine repository. See also e: labels. label Oct 17, 2019
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label Dec 10, 2020
@eggfly eggfly mentioned this issue Nov 25, 2021
Merged
8 tasks
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chinmaygarde @Hixie @gw280 @kf6gpe @darshankawar