Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GL in iOS simulator for tests #43028

Closed
gw280 opened this issue Oct 18, 2019 · 3 comments
Closed

Enable GL in iOS simulator for tests #43028

gw280 opened this issue Oct 18, 2019 · 3 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically
Projects
Mobile - iOS engine review

Comments

@gw280
Copy link
Contributor

gw280 commented Oct 18, 2019

Right now we don't have any real coverage of our GL rendering pipeline on iOS. Flutter for simulator forcibly uses the software backend for Skia, so we don't exercise any of our context management code in tests.

The primary reason for this (as I understand it) is to have better performance for developers writing Flutter applications and testing on simulator.

The iOS simulator doesn't have h/w accelerated GL (and even if it did, the GPU is different to mobile so it's largely irrelevant), but even with a software-backed implementation we can test our context management code which I believe adds a lot of value.
@janmoppel janmoppel added the platform-ios iOS applications specifically label Oct 21, 2019
@Hixie Hixie added this to the Goals milestone Jan 6, 2020
@Hixie Hixie added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. labels Jan 6, 2020
@jmagman jmagman added this to Awaiting triage in Mobile - iOS engine review Feb 25, 2020
@gaaclarke gaaclarke added the c: new feature Nothing broken; request for a new capability label Apr 6, 2020
@gaaclarke gaaclarke moved this from Awaiting triage to Engineer reviewed in Mobile - iOS engine review Apr 6, 2020
@gaaclarke gaaclarke mentioned this issue Apr 7, 2020
Closed
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label May 29, 2020
@Hixie Hixie removed this from the None. milestone Aug 17, 2020
@dingyq
Copy link

dingyq commented Jan 18, 2022

face same question, looking forward to the solution

@jmagman
Copy link
Member

jmagman commented Oct 5, 2022

The iOS OpenGL backend was removed flutter/engine#34913

@jmagman jmagman closed this as completed Oct 5, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically
Projects
Mobile - iOS engine review
  
Engineer reviewed
Milestone
No milestone
Development

No branches or pull requests
8 participants
@Hixie @jmagman @gw280 @kf6gpe @dingyq @janmoppel @gaaclarke @TahaTesser