Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dither parameter to dart:ui's Paint class #44134

Closed
jkurtw opened this issue Nov 4, 2019 · 2 comments · Fixed by flutter/engine#13868
Closed

Add a dither parameter to dart:ui's Paint class #44134

jkurtw opened this issue Nov 4, 2019 · 2 comments · Fixed by flutter/engine#13868
Labels
engine flutter/engine repository. See also e: labels.

Comments

@jkurtw
Copy link

jkurtw commented Nov 4, 2019

Gradients currently have a lot of color banding on all devices, and it looks very weird when using the pulse animation too. A solution is to make the gradients opaque, and to use dithered gradients with Skia. Dithered gradients aren't currently exposed, so adding a dither parameter to dart:ui's Paint class would be nice. We'd be able to manually draw our gradients with a CustomPainter.

b/143897620

@Hixie
Copy link
Contributor

Hixie commented Nov 20, 2019

We should just make our gradients look good, I don't think we should add specific controls like this.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants