Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared_preferences_platform_interface isn't being linted correctly #45627

Closed
mklim opened this issue Nov 26, 2019 · 1 comment · Fixed by flutter/plugins#2325
Closed

shared_preferences_platform_interface isn't being linted correctly #45627

mklim opened this issue Nov 26, 2019 · 1 comment · Fixed by flutter/plugins#2325
Assignees
@yjbanov
Labels
p: shared_preferences Plugin to read and write Shared Preferences package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Milestone
November 2019

Comments

@mklim
Copy link
Contributor

mklim commented Nov 26, 2019

When it was created the pre-existing linter exclusions from the original shared_preferences package were also applied to it since the analysis_options were at the top level. The analysis_options should be moved with the rest of the old shared_preferences package, and any linter failures in the new interface should be fixed.

/cc @yjbanov
@mklim mklim added plugin p: shared_preferences Plugin to read and write Shared Preferences team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Nov 26, 2019
@yjbanov yjbanov self-assigned this Nov 27, 2019
@yjbanov yjbanov added this to the November 2019 milestone Nov 27, 2019
@yjbanov yjbanov mentioned this issue Nov 27, 2019
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yjbanov yjbanov

Labels
p: shared_preferences Plugin to read and write Shared Preferences package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
November 2019
Development

Successfully merging a pull request may close this issue.

Implement shared_preferences on top of platform interface yjbanov/plugins
2 participants
@yjbanov @mklim