Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showCupertinoDialog should support barrierDismissible #45744

Closed
mehmetf opened this issue Nov 28, 2019 · 5 comments · Fixed by #50915
Closed

showCupertinoDialog should support barrierDismissible #45744

mehmetf opened this issue Nov 28, 2019 · 5 comments · Fixed by #50915
Labels
customer: google Various Google teams f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Comments

@mehmetf
Copy link
Contributor

mehmetf commented Nov 28, 2019

Internal: https://b.corp.google.com/issues/145094605

In showCupertinoDialog it is not supported to enabled to dismiss the dialog on outside tap. It seems that this might be the normal iOS behaviour, but I couldn't find any documentation that it is not allowed to support it.

@mehmetf mehmetf added customer: google Various Google teams f: cupertino flutter/packages/flutter/cupertino repository labels Nov 28, 2019
@HansMuller HansMuller added the framework flutter/packages/flutter repository. See also f: labels. label Dec 4, 2019
@alectogeek
Copy link

We realy need this feature!

@LongCatIsLooong
Copy link
Contributor

I couldn't find anything that says this is not allowed, but from https://developer.apple.com/design/human-interface-guidelines/ios/views/alerts/ it shouldn't be encouraged either, as barrierDismissible = true makes it a lot easier for users to dismiss something important by mistake:

Minimize alerts. Alerts disrupt the user experience and should only be used in important situations like confirming purchases and destructive actions (such as deletions), or notifying people about problems. The infrequency of alerts helps ensure that people take them seriously. Ensure that each alert offers critical information and useful choices.

Sounds reasonable to add the parameter but set the default to false.

@tottomotto
Copy link
Contributor

tottomotto commented Jan 29, 2020

@xster,can you please share your thoughts on this.
I Implemented the change (defaulting to false) and I can make a PR if it's ok.

@xster
Copy link
Member

xster commented Feb 4, 2020

Making it configurable (but defaulted to false) seems reasonable to me.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer: google Various Google teams f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
Development

Successfully merging a pull request may close this issue.

6 participants