Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PerformanceOverlayLayer set_paint_bounds() call into Preroll #45754

Open
arbreng opened this issue Nov 28, 2019 · 0 comments
Open

Move PerformanceOverlayLayer set_paint_bounds() call into Preroll #45754

arbreng opened this issue Nov 28, 2019 · 0 comments
Labels
c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@arbreng
Copy link
Contributor

arbreng commented Nov 28, 2019

Calling code has to call set_paint_bounds right now. See https://github.com/flutter/engine/blob/master/lib/ui/compositing/scene_builder.cc#L276

It would be more appropriate to make this a constructor parameter and move the set_paint_bounds into Preroll
@arbreng arbreng mentioned this issue Nov 28, 2019
Merged
@janmoppel janmoppel added the c: new feature Nothing broken; request for a new capability label Nov 28, 2019
@VladyslavBondarenko VladyslavBondarenko added the engine flutter/engine repository. See also e: labels. label Jan 15, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label Dec 10, 2020
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Hixie @kf6gpe @janmoppel @VladyslavBondarenko @arbreng @darshankawar