[theme] 'buttonColor' should depend from 'colorScheme'

[bitsydarel]

Steps to Reproduce

1- Create a material app widget
2- provide it a theme with a colorscheme
3- specify the home as a raisedbutton with a onPressed callback so that it's wont be disable.

Target Platform:
All
Target OS version/browser:
All
Devices:
All

As far as i understand, RaisedButton it's the material Contained Button, so the color of the button should be the primary color.

RaisedButton color is dependent on the ThemeData.buttonColor, ThemeData.buttonColor is equal to primarySwatch[600] which is not defined when using colorScheme , this line cause problem.

code to reproduce:

MaterialApp(
      theme: ThemeData.from(
        colorScheme: ColorScheme.light(),
      ),
      home: Center(child: RaisedButton(onPressed: () {})),
    )

there's many places in theme_data that are dependent on the primarySwatch field, which cause nightmares between us and our designers.

[alikamal1]

do you want to override the default button color? if so, you can set buttonColor to the color you want

MaterialApp(
      theme: ThemeData.from(
        colorScheme: ColorScheme.light(),
        buttonColor:  Colors.blue  // specify the color 
      ),
      home: Center(child: RaisedButton(onPressed: () {})),
    )

[bitsydarel]

Unfortunately I’m not looking for a workaround, this is a bug because this should be done by the framework when creating a theme with colorScheme.

[bitsydarel]

@alikamal1 also ThemeData.from does not accept any other parameters. The workaround would be to use the copyWith

[HansMuller]

CC @darrenaustin

[bitsydarel]

Any news on that issue ?
i think this should be labeled as fidelity because it's does not meet the material guideline

[HansMuller]

@bitsydarel it's been a long time since you opened this issue and I apologize for the lack of activity. If you're still interested in the topic, there's a wide-ranging proposal for updating the button widgets and their themes in #54776. The new proposal does bind the default button colors to the overall theme's ColorSchme, per the Material Design spec.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.