Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-selection toolbar affected by global styles #46238

Open
benPesso opened this issue Dec 6, 2019 · 2 comments
Open

Text-selection toolbar affected by global styles #46238

benPesso opened this issue Dec 6, 2019 · 2 comments
Labels
a: typography Text rendering, possibly libtxt c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@benPesso
Copy link

benPesso commented Dec 6, 2019

The text-selection toolbar seems to be affected by various global styles. Namely textTheme and buttonTheme.

In my opinion, the text-selection toolbar be completely isolated from the application's styles. I haven't come across any mobile application that customizes the style of this toolbar (other than adding a prefix-icon to them, like Google Translate).

NO ERRORS OR ISSUES FOUND IN LOGS/FLUTTER DOCTOR

No custom styles

original

Custom fontSize in textTheme

MaterialApp(
    ...
    theme: ThemeData(
        textTheme: TextTheme(
            button: TextStyle(
                fontSize: 24.0,
            ),
        ),
    ),
    ...
);

font-size

Custom ButtonTextTheme in buttonTheme

MaterialApp(
    ...
    theme: ThemeData(
        buttonTheme: ButtonThemeData(
            textTheme: ButtonTextTheme.primary,
        ),
    ),
    ...
);

button-color

@iapicca iapicca added a: typography Text rendering, possibly libtxt framework flutter/packages/flutter repository. See also f: labels. c: proposal A detailed proposal for a change to Flutter labels Dec 9, 2019
@HansMuller HansMuller added the f: material design flutter/packages/flutter/material repository. label Dec 9, 2019
@DrobyshevAlex
Copy link

I'm agree, it breaks UI

Снимок экрана 2020-05-23 в 18 23 27

Снимок экрана 2020-05-23 в 18 24 09

@benPesso
Copy link
Author

More than 2 years later, this is still an issue with Flutter 2.10.3. How can we get this escalated?

@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-design Owned by Design Languages team triaged-design Triaged by Design Languages team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: typography Text rendering, possibly libtxt c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Development

No branches or pull requests

5 participants