Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonTextTheme should have onPrimary option #46715

Closed
feinstein opened this issue Dec 10, 2019 · 3 comments
Closed

ButtonTextTheme should have onPrimary option #46715

feinstein opened this issue Dec 10, 2019 · 3 comments
Labels
c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@feinstein
Copy link
Contributor

feinstein commented Dec 10, 2019

ButtonTextTheme should have a onPrimary (and etc.) option, just like colorScheme has, this way the text inside a RaisedButton with a primary color and the background, would automatically get the right color for it's text, which is usually white or black, depending on the luminescence of the color, even if the ThemeData.brighness doesn't match the primary color.

Also, adding the option to set the actual color for text inside a button and thus be able to override any other options would be very much welcome.

@gaaclarke gaaclarke added framework flutter/packages/flutter repository. See also f: labels. c: new feature Nothing broken; request for a new capability labels Dec 10, 2019
@HansMuller HansMuller added the f: material design flutter/packages/flutter/material repository. label Dec 11, 2019
@HansMuller
Copy link
Contributor

@feinstein We're proposing a rather different approach for customizing the appearance of buttons in #54776. If you have time, we'd appreciate feedback on the proposal.

I'm going to close this issue in favor of #54776 .

@feinstein
Copy link
Contributor Author

Ok Hans, I will take a look at it next week.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

No branches or pull requests

3 participants