Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Incorrect behaviour of text cursor with 3D Touch #47610

Closed
sakyoyuto opened this issue Dec 22, 2019 · 16 comments · Fixed by #62415
Closed

[iOS] Incorrect behaviour of text cursor with 3D Touch #47610

sakyoyuto opened this issue Dec 22, 2019 · 16 comments · Fixed by #62415
Assignees
Labels
a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. f: gestures flutter/packages/flutter/gestures repository. found in release: 1.12 Found to occur in 1.12 found in release: 1.17 Found to occur in 1.17 found in release: 1.18 Occurs in 1.18 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list platform-ios iOS applications specifically

Comments

@sakyoyuto
Copy link

sakyoyuto commented Dec 22, 2019

Text cursor movement of iOS space key 3D Touch(Long press) does not work in Japanese keyboard.
Works in English keyboard.
It used to work, but it may have been a problem since iOS13.

Below is my doctor.

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.15.1 19B88,
    locale ja-JP)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from:
      https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK
      components.
      (or visit https://flutter.dev/setup/#android-setup for detailed
      instructions).
      If the Android SDK has been installed to a custom location, set
      ANDROID_HOME to that location.
      You may also want to add it to your PATH environment variable.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
[!] Android Studio (not installed)
[✓] VS Code (version 1.41.1)
[!] Connected device
    ! No devices available

Thank you.

@iapicca iapicca added f: gestures flutter/packages/flutter/gestures repository. platform-ios iOS applications specifically labels Dec 22, 2019
@shihaohong shihaohong added the framework flutter/packages/flutter repository. See also f: labels. label Dec 23, 2019
@goderbauer goderbauer added engine flutter/engine repository. See also e: labels. a: text input Entering text in a text field or keyboard related problems labels Jan 6, 2020
@sakyoyuto
Copy link
Author

@iapicca @shihaohong @goderbauer
I need help. Is there solution?

@shihaohong shihaohong added the c: regression It was better in the past than it is now label Feb 6, 2020
@shihaohong
Copy link
Contributor

cc/ @justinmc @GaryQian who might know more than I do about text editing and the keyboard

@justinmc
Copy link
Contributor

justinmc commented Feb 6, 2020

It seems to work for me on an iPhone 7 on iOS 13 with the default iOS Kana keyboard. I'm on the master channel. Are you doing anything different?

@sakyoyuto
Copy link
Author

sakyoyuto commented Feb 7, 2020

@justinmc
Thank you for your reply.

Apparently, such symptoms occur when Japanese is entered.
Attach the video.

RPReplay_Final1581038029_6x

I switched to the master channel and the same problem occurs.
Below is my doctor.

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.14.7-pre.83, on Mac OS X 10.15.2 19C57, locale
    ja-JP)
 
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.41.1)
[✓] Connected device (2 available)

• No issues found!

Thank you.

@justinmc
Copy link
Contributor

justinmc commented Feb 7, 2020

I tried again and I do see some weird movement of the cursor, but I don't see the stuck cursor like in your video. Do you get an error in the console when that happens?

@sakyoyuto
Copy link
Author

No errors are displayed on the console.

Cursor hovering and seems to freeze if you release the space key immediately. (Within 1 second)
If you keep pressing the space key, it starts to make weird movements.

Thank you.

@justinmc
Copy link
Contributor

justinmc commented Feb 7, 2020

Ok got it. I do see those same sorts of freezing cursor movements. I think that's a bug we should fix.

@sakyoyuto
Copy link
Author

Thank you.

@jmagman jmagman added this to Awaiting Triage in Mobile - iOS fidelity review Feb 25, 2020
@jmagman jmagman added this to Awaiting Triage in Mobile - localization & intl via automation Feb 25, 2020
@jmagman jmagman removed this from Awaiting Triage in Mobile - iOS fidelity review Feb 25, 2020
@goderbauer goderbauer added the a: internationalization Supporting other languages or locales. (aka i18n) label Mar 4, 2020
@goderbauer goderbauer added this to the Goals milestone Mar 18, 2020
@LoongZhi
Copy link

Ok got it. I do see those same sorts of freezing cursor movements. I think that's a bug we should fix.

Is there a solution?

@kongo2002
Copy link

I don't think this is any specific to Japanese at all. For me this happens with a regular English keyboard as well. I think it happens every time you don't actually move the cursor after long-pressing.

I posted this earlier to a very similar issue since I saw that one before (including a screen recording): #54413 (comment)

@VladyslavBondarenko VladyslavBondarenko changed the title [iOS]Text cursor movement of iOS space key 3D Touch does not work in Japanese. [iOS] Incorrect behaviour of text cursor with 3D Touch Apr 23, 2020
@VladyslavBondarenko
Copy link

Screen recording from #54413 (comment), thanks @kongo2002.

test

I can reproduce the same. It's not specific to the language.

flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0-6.0.pre, on Mac OS X 10.15.4 19E287, locale en-GB)
    • Flutter version 1.18.0-6.0.pre at /Users/nevercode/dev/flutter_dev
    • Framework revision 84c84fb249 (2 days ago), 2020-04-20 21:35:01 -0400
    • Engine revision 2bde4f0ae4
    • Dart version 2.9.0 (build 2.9.0-1.0.dev a12c36dd97)

 
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[✓] Connected device (5 available)
    • Android SDK built for x86 • emulator-5554                            • android-x86    • Android 10 (API 29) (emulator)
    • Nevercode’s iPhone        • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.4.5
    • macOS                     • macOS                                    • darwin-x64     • Mac OS X 10.15.4 19E287
    • Chrome                    • chrome                                   • web-javascript • Google Chrome 81.0.4044.122
    • Web Server                • web-server                               • web-javascript • Flutter Tools

• No issues found!

@VladyslavBondarenko VladyslavBondarenko added found in release: 1.17 Found to occur in 1.17 found in release: 1.12 Found to occur in 1.12 found in release: 1.18 Occurs in 1.18 has reproducible steps The issue has been confirmed reproducible and is ready to work on and removed a: internationalization Supporting other languages or locales. (aka i18n) labels Apr 23, 2020
@clocksmith clocksmith added this to Backlog in Material Flutter - Sprint 36 via automation Apr 23, 2020
@suztomo
Copy link

suztomo commented Apr 23, 2020

I noticed this cursor move bug behavior does not appear in release builds (good).

@kongo2002
Copy link

@suztomo are you sure about that? I originally noticed that bug on a release build, that's why it surprises me a lot.

@suztomo
Copy link

suztomo commented Apr 23, 2020

Now I’m not sure. My release build also shows the cursor bug today.

@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label May 29, 2020
@ghost

This comment has been minimized.

@guidezpl guidezpl self-assigned this Jul 21, 2020
@guidezpl guidezpl modified the milestones: [DEPRECATED] Goals, 1.22 - August 2020 Jul 21, 2020
@clocksmith clocksmith moved this from Backlog to Current Sprint in Material Flutter - Sprint 36 Jul 21, 2020
Material Flutter - Sprint 36 automation moved this from Current Sprint to Done Aug 3, 2020
Mobile - localization & intl automation moved this from Awaiting Triage to Engineer Reviewed Aug 3, 2020
@clocksmith clocksmith moved this from Done to Done in Previous Sprints in Material Flutter - Sprint 36 Aug 19, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. f: gestures flutter/packages/flutter/gestures repository. found in release: 1.12 Found to occur in 1.12 found in release: 1.17 Found to occur in 1.17 found in release: 1.18 Occurs in 1.18 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list platform-ios iOS applications specifically
Projects
Mobile - localization & intl
  
Engineer Reviewed
Material Flutter - Sprint 36
  
Done in Previous Sprints
Development

Successfully merging a pull request may close this issue.