Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pickers are not focusable when using a keyboard #49182

Closed
gmoraja opened this issue Jan 20, 2020 · 6 comments
Closed

Some pickers are not focusable when using a keyboard #49182

gmoraja opened this issue Jan 20, 2020 · 6 comments
Labels
a: desktop Running on desktop customer: soldier f: cupertino flutter/packages/flutter/cupertino repository f: date/time picker Date or time picker widgets f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@gmoraja
Copy link

gmoraja commented Jan 20, 2020

@goderbauer
@gspencergoog
@lorenzOliveto

@iapicca iapicca added a: desktop Running on desktop customer: soldier f: cupertino flutter/packages/flutter/cupertino repository f: date/time picker Date or time picker widgets f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 21, 2020
@gspencergoog
Copy link
Contributor

cc @darrenaustin

@darrenaustin
Copy link
Contributor

We might want to split this into separate bugs, as there are four different pickers involved here.

The Cupertino pickers will be hard to fix until we get general keyboard support for macOS. I'll let @gspencergoog address this as he has more knowledge about what needs to be done here.

For the Material date picker, the calendar grid is the main thing part that is not keyboard focusable. We can probably just add inkwells for each of the date entries. However, as we have a complete redesign of this picker coming in with the new date range picker, it might be better to just hold off on this until we replace the existing UI.

For the Material time picker it is not clear what we should do for the keyboard navigation here, as the dials don't have an obvious keyboard traversal. I will submit a YAQS design question for this and see if we can get some UI design help here.

@Hixie
Copy link
Contributor

Hixie commented Jan 29, 2020

@gmoraja Can you please file separate bugs for each picker you would like updated?

@Hixie Hixie added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 29, 2020
@gmoraja
Copy link
Author

gmoraja commented Jan 30, 2020

@Hixie I created the following issues:

Material date picker is not focusable with a keyboard
#49809

Material time picker is not focusable with a keyboard
#49810

Cupertino pickers are not focusable with a keyboard
#49811

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 30, 2020
@goderbauer
Copy link
Member

I am closing this issue since we now have sub-issues tracking all the work necessary.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: desktop Running on desktop customer: soldier f: cupertino flutter/packages/flutter/cupertino repository f: date/time picker Date or time picker widgets f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

No branches or pull requests

7 participants