Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ShellTestPlatformView fully runtime configurable #50298

Open
gw280 opened this issue Feb 6, 2020 · 1 comment
Open

Make ShellTestPlatformView fully runtime configurable #50298

gw280 opened this issue Feb 6, 2020 · 1 comment
Labels
engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-fuchsia Fuchsia code specifically team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@gw280
Copy link
Contributor

gw280 commented Feb 6, 2020

Right now there is #ifdef soup in ShellTestPlatformView.cc in order to determine which backends are available.

We'd like to move to a system where all backends are built for ShellTest and at runtime we do proc resolution for GL or Vulkan symbols then determine which backends can be run based off that.

This is currently not possible because the code doesn't compile on all platforms (e.g. //testing/opengl won't compile on Fuchsia, //flutter/vulkan won't compile on Windows).
@gw280 gw280 added this to the June 2020 milestone Feb 6, 2020
@gw280 gw280 mentioned this issue Feb 6, 2020
Merged
@VladyslavBondarenko VladyslavBondarenko added engine flutter/engine repository. See also e: labels. platform-fuchsia Fuchsia code specifically labels Feb 7, 2020
@kf6gpe kf6gpe added the P1 High-priority issues at the top of the work list label May 29, 2020
@arbreng
Copy link
Contributor

arbreng commented Jun 13, 2020

Unfortunately I'm not sure it's possible to get rid of the ifdefs here... in my experiences getting embedder API to work I'm really leaning on the SHELL_ENABLE_GL to remove all the GL stuff on Fuchsia.

//testing/opengl will never compile on Fuchsia, unless we use ANGLE...

Metal won't ever work on anything though :(

@Hixie Hixie removed this from the 1.20 - June 2020 milestone Jul 7, 2020
@chinmaygarde chinmaygarde added P3 Issues that are less important to the Flutter project and removed P1 High-priority issues at the top of the work list labels Aug 31, 2020
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-fuchsia Fuchsia code specifically team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chinmaygarde @Hixie @gw280 @kf6gpe @VladyslavBondarenko @arbreng