Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video_player plugin needs to more explicitly state it supports Web in the README. #55340

Closed
ditman opened this issue Apr 21, 2020 · 2 comments
Closed

video_player plugin needs to more explicitly state it supports Web in the README. #55340

ditman opened this issue Apr 21, 2020 · 2 comments
Assignees
@mariamhas
Labels
good first issue Relatively approachable for first-time contributors p: video_player The Video Player plugin package flutter/packages repository. See also p: labels.
Projects
Flutter Web Plugins

Comments

@ditman
Copy link
Member

ditman commented Apr 21, 2020

Steps to Reproduce

The first sentence of the README of the video_player plugin seems to suggest that the plugin only supports iOS and Android.

It should be updated to reflect that the plugin also supports the web platform.

Reported by: @mariamhas
@ditman ditman added plugin p: video_player The Video Player plugin good first issue Relatively approachable for first-time contributors labels Apr 21, 2020
@ditman ditman added this to the Near-term Goals milestone Apr 21, 2020
@ditman ditman self-assigned this Apr 21, 2020
@ditman ditman added this to Not Started in Flutter Web Plugins via automation Apr 21, 2020
@mariamhas mariamhas assigned mariamhas and unassigned ditman Apr 21, 2020
@mariamhas mariamhas mentioned this issue Apr 22, 2020
Merged
1 task
@ditman ditman moved this from Not Started to Writing Web Implementation in Flutter Web Plugins Apr 22, 2020
This was referenced Apr 23, 2020
Closed
Merged
@ditman
Copy link
Member Author

ditman commented Apr 23, 2020 •
edited

The fix for this issue has been published. Thanks @mariamhas for the contribution!!

@ditman ditman closed this as completed Apr 23, 2020
Flutter Web Plugins automation moved this from Writing Web Implementation to Done Apr 23, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mariamhas mariamhas

Labels
good first issue Relatively approachable for first-time contributors p: video_player The Video Player plugin package flutter/packages repository. See also p: labels.
Projects
Flutter Web Plugins
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ditman @mariamhas