Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Android 11 display cutouts, waterfall #56599

Closed
xster opened this issue May 7, 2020 · 5 comments · Fixed by flutter/engine#20921
Closed

Support Android 11 display cutouts, waterfall #56599

xster opened this issue May 7, 2020 · 5 comments · Fixed by flutter/engine#20921
Assignees
@GaryQian
Labels
c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically
Projects
Mobile - Android next adoption review
Milestone
1.22 - August 2020

Comments

@xster
Copy link
Member

xster commented May 7, 2020 •
edited

DisplayCutout.getSafeInset…() now returns screen safe areas like iOS

We can also follow the keyboard animation now with setOnApplyWindowInsetsListener(new View.OnApplyWindowInsetsListener())

We can also move the keyboard now with getWindowInsetsController().controlWindowInsetsAnimation() to support #57609 on Android

Need to do #56597 first~~
@xster xster added platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels May 7, 2020
@xster xster mentioned this issue May 19, 2020
Open
@xster xster added the framework flutter/packages/flutter repository. See also f: labels. label Jun 4, 2020
@xster xster mentioned this issue Jun 5, 2020
Open
@xster
Copy link
Member Author

xster commented Aug 4, 2020

Splitting keyboard synchronization to #62876

@xster xster changed the title Support Android 11 display cutouts, waterfall, synchronized IME Support Android 11 display cutouts, waterfall Aug 4, 2020
@xster xster added this to the 1.22 - August 2020 milestone Aug 10, 2020
@pcsosinski pcsosinski added the c: new feature Nothing broken; request for a new capability label Aug 20, 2020
@xster xster added this to Engineer reviewed in Mobile - Android next adoption review Aug 27, 2020
@xster
Copy link
Member Author

xster commented Aug 27, 2020

The upstream API has been slightly updated. New doc https://developer.android.com/reference/android/view/DisplayCutout

@GaryQian GaryQian mentioned this issue Sep 1, 2020
Merged
@GaryQian
Copy link
Contributor

GaryQian commented Sep 1, 2020

flutter/engine#20921 Implements merging DisplayCutouts into existing API.

@GaryQian GaryQian mentioned this issue Sep 2, 2020
Open
@GaryQian
Copy link
Contributor

GaryQian commented Sep 2, 2020

I filed a new issue to track exposing the detailed rects #65088

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GaryQian GaryQian

Labels
c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically
Projects
Mobile - Android next adoption review
  
Engineer reviewed
Milestone
1.22 - August 2020
Development

Successfully merging a pull request may close this issue.

[Android R] Integrate DisplayCutouts into viewportMetrics GaryQian/engine
3 participants
@xster @GaryQian @pcsosinski