Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dart VM aware of growing size/weight of Canvas #58437

Closed
dnfield opened this issue Jun 1, 2020 · 4 comments
Closed

Make Dart VM aware of growing size/weight of Canvas #58437

dnfield opened this issue Jun 1, 2020 · 4 comments
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project perf: memory Performance issues related to memory

Comments

@dnfield
Copy link
Contributor

dnfield commented Jun 1, 2020

For example, when we draw an image to a canvas, we should inform the VM that the canvas' allocation size is now higher to include the image.

We'll be able to do this once https://dart-review.googlesource.com/c/sdk/+/149245 lands

/cc @chinmaygarde @liyuqian @rmacnak-google

@dnfield dnfield added engine flutter/engine repository. See also e: labels. perf: memory Performance issues related to memory dependency: dart Dart team may need to help us P1 High-priority issues at the top of the work list labels Jun 1, 2020
@liyuqian liyuqian added the c: performance Relates to speed or footprint issues (see "perf:" labels) label Jul 9, 2020
@chinmaygarde
Copy link
Member

Does the framework hold references to Canvases directly very often? My expectation was that pictures were the long lived heavyweight objects.

@dnfield
Copy link
Contributor Author

dnfield commented Aug 10, 2020

No, I think we can lower the priority on this until we have a user who needs it or some convincing evidence that it's needed.

@dnfield dnfield added P3 Issues that are less important to the Flutter project and removed P1 High-priority issues at the top of the work list labels Aug 10, 2020
@dnfield
Copy link
Contributor Author

dnfield commented Jan 25, 2022

Now that we properly dispose Canvas/Picture objects this is not necessary.

@dnfield dnfield closed this as completed Jan 25, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project perf: memory Performance issues related to memory
Projects
None yet
Development

No branches or pull requests

4 participants