Increase test coverage for getOffsetToReveal and SliverAppBars #59181
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
a: tests
"flutter test", flutter_test, or one of our tests
f: focus
Focus traversal, gaining or losing focus
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
P2
Important issues not at the top of the work list
team-framework
Owned by Framework team
triaged-framework
Triaged by Framework team
Comments
Piinks
added
framework
|
fyi @goderbauer |
TahaTesser
added
passed first triage
a: tests
flutter-triage-bot
bot
added
team-framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SliverGeometry.maxScrollObstructionExtentis used to correct a11y focus navigation when an app bar may be overlapping a portion of scrollable area. This makes it possible to go from the app bar to the next visible sliver after the overlap, rather than traversing the slivers under the app bar.The tests for this cover
pinnedSliverAppBars in aCustomScrollView(see #11878 for original tests), but we should have coverage forfloatingandfloating-pinnedSliverAppBars as well. Plus, all three in aNestedScrollView.Related PRs:
#11878 - added maxScrollObstructionExtent to floating, pinned and floating-pinned app bars, integrating with getOffsetToReveal
#39263 - changes maxScrollObstruction extent for floating app bars
#57707 - changes maxScrollObstructionExtent for floating-pinned app bars
The text was updated successfully, but these errors were encountered: