Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutlineButton missing materialTapTargetSize property in constructor #61061

Closed
NoizyCr1cket opened this issue Jul 8, 2020 · 4 comments
Closed

OutlineButton missing materialTapTargetSize property in constructor #61061

NoizyCr1cket opened this issue Jul 8, 2020 · 4 comments
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@NoizyCr1cket
Copy link

Use case

The OutlineButton's constructor doesn't allow for specifying a value for materialTapTargetSize, while other buttons do (RaisedButton, FlatButton, FloatingActionButton and MaterialButton).

Proposal

Include materialTapTargetSize in the OutlineButton's constructor.

See comment here where this was intended to be included in a PR, but was not: #27575 (comment).
@darshankawar darshankawar added c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 8, 2020
@md-weber
Copy link
Contributor

md-weber commented Jul 8, 2020

I would like to work on this issue, and work on the missing value. @shihaohong @Piinks

@md-weber md-weber mentioned this issue Jul 8, 2020
Merged
9 tasks
@HansMuller
Copy link
Contributor

HansMuller commented Jul 8, 2020 •
edited

@md-weber - Should be an easy fix, please submit a PR!

@md-weber
Copy link
Contributor

md-weber commented Jul 10, 2020 •
edited

The issue can be closed - Fix in #61086
@TahaTesser

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@HansMuller @md-weber @NoizyCr1cket @shihaohong @darshankawar