Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline text incorrectly calculates intrinsic height #62619

Open
matthew-carroll opened this issue Jul 30, 2020 · 4 comments
Open

multiline text incorrectly calculates intrinsic height #62619

matthew-carroll opened this issue Jul 30, 2020 · 4 comments
Labels
a: typography Text rendering, possibly libtxt framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@matthew-carroll
Copy link
Contributor

Multiline text on web appears to compute the wrong intrinsic height. Here is a repo of the problem occurring:

https://dartpad.dev/9059244f9a737f01f73242c2f7f174f5

Run the Dart Pad and press the button at the bottom of the screen. You'll see an overflow that shouldn't happen.

Here is the same Dart Pad with only a single line of text and the overflow does not occur:

https://dartpad.dev/9795697f867daf7175f9716273c2fb3b

This bug seems to still exist even with the FLUTTER_WEB_USE_EXPERIMENTAL_CANVAS_TEXT flag.

@matthew-carroll matthew-carroll added the platform-web Web applications specifically label Jul 30, 2020
@Piinks Piinks added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jul 31, 2020
@mdebbar
Copy link
Contributor

mdebbar commented Aug 6, 2020

This issue only happens when the window exceeds a certain width. If I shrink the window size in your repro DartPad, the overflow goes away:
image
Here's what it looks like when I increase the width after a certain point:
image

I was able to repro this on native iOS when I use landscape mode to get the necessary width:
image
image

@yjbanov
Copy link
Contributor

yjbanov commented Aug 6, 2020

Removing the web label as this is not web-specific. /cc @goderbauer @HansMuller

@yjbanov yjbanov removed the platform-web Web applications specifically label Aug 6, 2020
@goderbauer goderbauer removed the a: text input Entering text in a text field or keyboard related problems label Aug 6, 2020
@goderbauer
Copy link
Member

This is most likely a duplicate of #48679. The way RenderParagraph calculates its intrinsics is buggy.

@pedromassangocode pedromassangocode changed the title [Web] multiline text incorrectly calculates intrinsic height multiline text incorrectly calculates intrinsic height Sep 18, 2020
@pedromassangocode
Copy link

This is most likely a duplicate of #48679. The way RenderParagraph calculates its intrinsics is buggy.

@goderbauer can you please confirm that this can be closed in favour of the one you mentioned?

@pedromassangocode pedromassangocode added a: typography Text rendering, possibly libtxt passed first triage labels Sep 18, 2020
@goderbauer goderbauer added the P2 Important issues not at the top of the work list label Aug 16, 2022
@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: typography Text rendering, possibly libtxt framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Development

No branches or pull requests

7 participants