Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase plugin template minimum supported iOS version from 8.0 to 9.0 #63253

Closed
jmagman opened this issue Aug 8, 2020 · 4 comments · Fixed by #66590
Closed

Increase plugin template minimum supported iOS version from 8.0 to 9.0 #63253

jmagman opened this issue Aug 8, 2020 · 4 comments · Fixed by #66590
Labels
P1 High-priority issues at the top of the work list platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Tools - flutter create review

Comments

@jmagman
Copy link
Member

jmagman commented Aug 8, 2020

#60035 but for plugins.

Flutter apps with minimum versions of 8.0 (so current 1.20 and older) will not be able to use plugins with a higher minimum version.
@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Aug 8, 2020
@jmagman jmagman added this to Awaiting triage in Tools - flutter create review via automation Aug 8, 2020
@jmagman
Copy link
Member Author

jmagman commented Aug 8, 2020 •
edited

Flutter apps with minimum versions of 8.0 (so current 1.20 and older) will not be able to use plugins with a higher minimum version. The error manifests on the app side like this: #56935
I'm not sure this one is a good idea without a corresponding Flutter SDK plugin pubspec.yaml bump.

@jmagman jmagman mentioned this issue Aug 8, 2020
Closed
8 tasks
@jmagman
Copy link
Member Author

jmagman commented Aug 8, 2020

See also #40109 and #36117

@jmagman jmagman added the P1 High-priority issues at the top of the work list label Aug 11, 2020
@TahaTesser TahaTesser mentioned this issue Aug 21, 2020
Closed
@jmagman jmagman mentioned this issue Sep 24, 2020
Merged
10 tasks
@jmagman
Copy link
Member Author

jmagman commented Sep 24, 2020

Instead of changing the minimum for plugins, which then have to be migrated, let's simplify things by removing the useless warning: #66590

Tools - flutter create review automation moved this from Awaiting triage to Engineer reviewed Sep 28, 2020
@jmagman jmagman mentioned this issue Mar 4, 2021
Closed
8 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1 High-priority issues at the top of the work list platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Tools - flutter create review
  
Engineer reviewed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force plugins to inherit minimum iOS version from Flutter app jmagman/flutter
1 participant
@jmagman