Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for InputDecoration gives accent to wrong words #65034

Closed
broccolism opened this issue Sep 1, 2020 · 5 comments
Closed

Documentation for InputDecoration gives accent to wrong words #65034

broccolism opened this issue Sep 1, 2020 · 5 comments
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@broccolism
Copy link
Contributor

I found out this using Flutter as in my work.
Below is the documentation of InputDecoration's contentPadding property.

docs issue

As you may see, documentation's accent seems something wrong.
For example, ". If isOutlineproperty of [border] is false and if [filled] is false thencontentPaddingisEdgeInsets.fromLTRB(0, 8, 0,......" in line 5 in the picture.

I think this should be fixed. Thanks!
@broccolism broccolism changed the title Documentation for InputDecoration accents wrong words Documentation for InputDecoration gives accent wrong words Sep 2, 2020
@broccolism broccolism changed the title Documentation for InputDecoration gives accent wrong words Documentation for InputDecoration gives accent to wrong words Sep 2, 2020
@darshankawar darshankawar added d: api docs Issues with https://api.flutter.dev/ documentation labels Sep 2, 2020
@darshankawar
Copy link
Member

Correct accent should be:
If isOutline property of [border] is false and if [filled] is false then contentPadding is EdgeInsets.from LTRB(0,8,08) when [isDense] is true and EdgeInsets.fromLTRB(0,12,0,12) when [isDense] is false.

@TahaTesser TahaTesser added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 2, 2020
@TomRvr TomRvr mentioned this issue Sep 2, 2020
Merged
13 tasks
@TomRvr
Copy link
Contributor

TomRvr commented Sep 2, 2020

Hi !
I fixed the accent issue and submitted a PR #65094

It's my first contribution, let me know if I did Something wrong.

@DeadlyMissile
Copy link

PR was merged. This can be closed

@darshankawar
Copy link
Member

Closing this as fixed. Please check in latest master.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DeadlyMissile @broccolism @TomRvr @TahaTesser @darshankawar