-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate the path to gems file directly from the generated folder #65888
Comments
\cc @jmagman @drewroengoogle @ricardoamador this is related to the error in arm64 cross arch tests. |
The way rubygems is designed does not play nicely with a tool like cipd. @ricardoamador do you have a build log with a relevant crash? |
@christopherfujino take a look here: https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64%20tool_host_cross_arch_tests?cursor=id%3E8800936530191176481&limit=25
|
Per the stacktrace, it looks like this line is failing:
And not the |
However, per the steps that we see rendered, we must have hit api.flutter_deps.gems(). Another case where I'm stumped because I don't know how python works... Ahh ok never mind, I was reading the stacktrace upside down, we are indeed inside flutter_deps.gems |
So it looks like we're installing bundler into Maybe the solution here is to invoke bundler with the absolute path here: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/flutter_deps/api.py#319 |
Correct. I think that is what Godofredo is saying here. |
Removing myself from this bug, @drewroengoogle @keyonghan this can addressed when landing the changes to the ruby cipd package. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
The gems bundler is adding a the ruby version in the path and it may be different depending on the test bed it is running. We need to get the values to add to the path and GEM_HOME env directly from the generated folder instead of hardcoding the path to a given version of ruby.
The text was updated successfully, but these errors were encountered: