Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate the path to gems file directly from the generated folder #65888

Closed
godofredoc opened this issue Sep 15, 2020 · 11 comments
Closed

Calculate the path to gems file directly from the generated folder #65888

godofredoc opened this issue Sep 15, 2020 · 11 comments
Assignees
Labels
P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team

Comments

@godofredoc
Copy link
Contributor

The gems bundler is adding a the ruby version in the path and it may be different depending on the test bed it is running. We need to get the values to add to the path and GEM_HOME env directly from the generated folder instead of hardcoding the path to a given version of ruby.

@godofredoc godofredoc self-assigned this Sep 15, 2020
@godofredoc godofredoc added the team-infra Owned by Infrastructure team label Sep 15, 2020
@godofredoc godofredoc added this to To do in Migration to LUCI via automation Sep 15, 2020
@godofredoc
Copy link
Contributor Author

\cc @christopherfujino

@digiter digiter added the P1 High-priority issues at the top of the work list label Sep 24, 2020
@godofredoc
Copy link
Contributor Author

\cc @jmagman @drewroengoogle @ricardoamador this is related to the error in arm64 cross arch tests.

@christopherfujino
Copy link
Member

The way rubygems is designed does not play nicely with a tool like cipd. @ricardoamador do you have a build log with a relevant crash?

@ricardoamador
Copy link
Contributor

@christopherfujino take a look here: https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64%20tool_host_cross_arch_tests?cursor=id%3E8800936530191176481&limit=25
The error reported each time is this:

Uncaught Exception: FileNotFoundError('2', 'No such file or directory')

@christopherfujino
Copy link
Member

Per the stacktrace, it looks like this line is failing:

        api.flutter_deps.gems(
            env, env_prefixes, checkout_path.join('dev', 'ci', 'mac')
        )

And not the flutter_deps module itself, which surprises me.

@christopherfujino
Copy link
Member

christopherfujino commented Oct 20, 2022

Per the stacktrace, it looks like this line is failing:

        api.flutter_deps.gems(
            env, env_prefixes, checkout_path.join('dev', 'ci', 'mac')
        )

And not the flutter_deps module itself, which surprises me.

However, per the steps that we see rendered, we must have hit api.flutter_deps.gems(). Another case where I'm stumped because I don't know how python works...

Ahh ok never mind, I was reading the stacktrace upside down, we are indeed inside flutter_deps.gems

@christopherfujino
Copy link
Member

@ricardoamador
Copy link
Contributor

Correct. I think that is what Godofredo is saying here.

@godofredoc godofredoc removed their assignment Oct 26, 2022
@godofredoc
Copy link
Contributor Author

Removing myself from this bug, @drewroengoogle @keyonghan this can addressed when landing the changes to the ruby cipd package.

@godofredoc godofredoc self-assigned this Jan 10, 2023
@godofredoc
Copy link
Contributor Author

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team
Projects
Development

No branches or pull requests

5 participants