The highlight frame of RaisedButton lost when need gesture disambiguation #66087
Labels
a: quality
A truly polished experience
f: material design
flutter/packages/flutter/material repository.
found in release: 1.22
Found to occur in 1.22
framework
flutter/packages/flutter repository. See also f: labels.
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
waiting for customer response
The Flutter team cannot make further progress on this issue until the original reporter responds
Comments
|
Hi @xu-baolin |
pedromassangocode
added
in triage
|
@pedromassangocode void updateHighlight(_HighlightType type, { @required bool value, bool callOnHover = true }) {
print('updateHighlight[$type][$value][${DateTime.now()}]');
debugPrintStack();
final InkHighlight highlight = _highlights[type];
void handleInkRemoval() {
assert(_highlights[type] != null);
_highlights[type] = null;
updateKeepAlive();
}
... |
no-response
bot
removed
the
waiting for customer response
|
Hi @xu-baolin |
pedromassangocode
added
the
waiting for customer response
|
@pedromassangocode flutter/packages/flutter/lib/src/material/ink_well.dart Lines 825 to 832 in 511367a |
no-response
bot
removed
the
waiting for customer response
|
I was able to reproduce this on latest Logsflutter doctor -v |
pedromassangocode
added
a: quality
|
Also CC @goderbauer |
|
Just chatted with @HansMuller . He's been working on buttons so he'll take a look at this issue 😄 |
|
RaisedButton has been removed from the framework and replaced by ElevatedButton. In the new API, in accordance with updated Material Design specs, highlight color no longer exists, so I think we may be able to close this issue now. |
Piinks
added
the
waiting for customer response
|
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This issue comes from #65849
Descriptions
From the logs, we can see that the frame of the highlight was merged because the occurrence and disappearance of the highlight are triggered in the same vsync, so we can not see the highlight frame.
This only happens when there is a gesture competition.
Logs and Sample Code
With gesture competition
updateHighlight [true][2020-09-16 11:34:50.470907]
updateHighlight [false][2020-09-16 11:34:50.479360]
Without gesture competition
updateHighlight [true][2020-09-16 11:30:14.828048]
updateHighlight [false][2020-09-16 11:30:14.873896]
The text was updated successfully, but these errors were encountered: