Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in worst_frame_build_time_millis cubic_bezier_perf__e2e_summary. #66986

Closed
kf6gpe opened this issue Sep 30, 2020 · 4 comments
Closed

Regression in worst_frame_build_time_millis cubic_bezier_perf__e2e_summary. #66986

kf6gpe opened this issue Sep 30, 2020 · 4 comments
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks

Comments

@kf6gpe
Copy link
Contributor

kf6gpe commented Sep 30, 2020 •
edited

https://flutter-flutter-perf.skia.org/e/?begin=1600827934&end=1601429824&keys=X197f56aeb2671ed26940c2a2de56e74d&requestType=0&xbaroffset=21704

Pretty clear signal at #66743. Looks to me like a test change --- so we should likely accept this one, right? Marking lower-priority as a result.

/cc @liyuqian
@kf6gpe kf6gpe added perf: speed Performance issues related to (mostly rendering) speed c: performance Relates to speed or footprint issues (see "perf:" labels) team: benchmark Performance issues found by inspecting benchmarks engine flutter/engine repository. See also e: labels. P2 c: regression It was better in the past than it is now labels Sep 30, 2020
@liyuqian
Copy link
Contributor

#66743 seems to be a very small and innocent change which shouldn't affect this benchmark... I zoomed out the time a little and see a similar regression before #66130 that has the similar level of regression as this one. I agree that this is of lower priority, and we may want to have someone to try to reproduce this locally to make sure that it's not some noisy results from infra changes.

@chinmaygarde chinmaygarde added P2 Important issues not at the top of the work list and removed P2 labels Oct 5, 2020
@chinmaygarde
Copy link
Member

@liyuqian This looks bimodal. Are you able to dedicate some time to reproduce this locally. Either way, I don't think this is severe enough for a P2. Please revise the priority if you disagree.
Screen Shot 2020-10-05 at 10 37 14 AM

@kf6gpe
Copy link
Contributor Author

kf6gpe commented Nov 16, 2020

This has recovered since 19 October. Closing.
https://flutter-flutter-perf.skia.org/e/?begin=1602565416&end=1605551441&queries=test%3Dcubic_bezier_perf__e2e_summary&requestType=0

@kf6gpe kf6gpe closed this as completed Nov 16, 2020
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chinmaygarde @kf6gpe @liyuqian @pedromassangocode