Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selectionOverlay parameter to CupertinoTimerPicker #68509

Open
sanekyy opened this issue Oct 19, 2020 · 13 comments
Open

Add selectionOverlay parameter to CupertinoTimerPicker #68509

sanekyy opened this issue Oct 19, 2020 · 13 comments
Labels
c: proposal A detailed proposal for a change to Flutter f: cupertino flutter/packages/flutter/cupertino repository f: date/time picker Date or time picker widgets framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
iOS Platform - Cupertino widget review

Comments

@sanekyy
Copy link

sanekyy commented Oct 19, 2020

[✓] Flutter (Channel dev, 1.23.0-18.0.pre, on Mac OS X 10.15.7 19H2 x86_64, locale en-RU)
@sanekyy sanekyy changed the title Add to CupertinoTimerPicker selectionOverlay paramater Add to CupertinoTimerPicker selectionOverlay parameter Oct 19, 2020
@darshankawar darshankawar changed the title Add to CupertinoTimerPicker selectionOverlay parameter Add selectionOverlay parameter to CupertinoTimerPicker Oct 20, 2020
@darshankawar darshankawar added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. passed first triage c: proposal A detailed proposal for a change to Flutter f: date/time picker Date or time picker widgets labels Oct 20, 2020
@jmagman jmagman added this to Awaiting triage in iOS Platform - Cupertino widget review via automation Oct 22, 2020
@DanielEdrisian
Copy link
Contributor

@sanekyy Can you provide more context on this issue?

@DanielEdrisian DanielEdrisian added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Oct 30, 2020
@sanekyy
Copy link
Author

sanekyy commented Oct 30, 2020

I can't provide selectionOverlay to CupertinoTimerPicker to override default value of this parameter.

I want customize it, but I can't with current api.

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Oct 30, 2020
@lecicdjuro
Copy link

lecicdjuro commented Apr 1, 2021 •
edited

CupertinoDatePicker doesn't have optional param for selectionOverlay Widget, so it can't be overridden or changed.
This class should have the same option as CupertinoPicker, so we can change this overlay widget.

@DanielEdrisian I'm using the latest stable version

[✓] Flutter (Channel stable, 2.0.3, on macOS 11.2.3 20D91 darwin-x64, locale en-RS)
• Flutter version 2.0.3 at /Users/lecicdjuro/flutter
• Framework revision 4d7946a (2 weeks ago), 2021-03-18 17:24:33 -0700
• Engine revision 3459eb2
• Dart version 2.12.2

@TahaTesser TahaTesser mentioned this issue Apr 5, 2021
Open
@daadu
Copy link
Contributor

daadu commented May 18, 2021

I think the right design for this would be to not add Widget selectionOverlay to either CupertinoTimePicker or CupertinoDateTimePicker, or any other "Picker".

Instead I propose to add pickerSelectionColor to CupertinoTheme (defaulting to CupertinoColors.tertiarySystemFill), and the CupertinoPickerDefaultSelectionOverlay used underneath CupertinoPicker, defaults to CupertinoTheme.pickerSelectionColor.

@TetrixGauss
Copy link

what is going on with that update????

@binSaed
Copy link

binSaed commented Oct 6, 2022

Any update? or everything in flutter we need to rebuild from scratch!

1 similar comment
@Deepakuklan
Copy link

Any update? or everything in flutter we need to rebuild from scratch!

@bgoncharuck
Copy link

We need this feature in many projects with custom design!

@PashnyukD
Copy link

It was open since 2020, how long to wait?!

@nosovk
Copy link

nosovk commented Jun 16, 2023

It would be nice to have that in base library (without using some handmaid stuff, just from the box)

@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-design Owned by Design Languages team triaged-design Triaged by Design Languages team labels Jul 8, 2023
@Requieem
Copy link

Are there any updates on this? Looking at the source code it should be a rather straightforward fix, and It would be much appreciated in many Cupertino-based projects.

@flutter-triage-bot flutter-triage-bot bot removed the triaged-design Triaged by Design Languages team label Mar 30, 2024
@flutter-triage-bot
Copy link

This issue is missing a priority label. Please set a priority label when adding the triaged-design label.

@HansMuller HansMuller added the P2 Important issues not at the top of the work list label Apr 3, 2024
@HansMuller HansMuller added the triaged-design Triaged by Design Languages team label Apr 3, 2024
@HansMuller
Copy link
Contributor

A fix appears to be underway - #143079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter f: cupertino flutter/packages/flutter/cupertino repository f: date/time picker Date or time picker widgets framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
iOS Platform - Cupertino widget review
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests