Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Emoji insertion via Ctrl-Shift-E incorrectly positions completions #68549

Open
cbracken opened this issue Oct 20, 2020 · 4 comments
Open
Labels
a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems P2 Important issues not at the top of the work list platform-linux Building on or for Linux specifically team-linux Owned by the Linux platform team triaged-linux Triaged by the Linux platform team

Comments

@cbracken
Copy link
Member

Description

In flutter/engine#21897, I landed support for multi-step input methods, which also added support for unicode codepoint insertion via Ctrl-Shift-U and emoji insertion via Ctrl-Shift-E.

That said, the completion window position when not in composing mode (e.g. for emoji) is incorrect.

To support this, I believe we'll need notify the GTK embedder of every change to the cursor position (even when not in composing mode), then remove these lines. Removing those lines currently results in incorrect positioning of the IM window when composing mode is entered after committing a previous composing region.

Expected behaviour

image

Current behaviour

image

@cbracken cbracken added a: text input Entering text in a text field or keyboard related problems platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Oct 20, 2020
@cbracken
Copy link
Member Author

@dkwingsmt do we currently send the cursor rect on each keypress even when not in composing mode?

@dkwingsmt
Copy link
Contributor

@gspencergoog or @stuartmorgan might be a better person to answer this :)

@gspencergoog gspencergoog added the P2 Important issues not at the top of the work list label Oct 21, 2020
@cbracken
Copy link
Member Author

Oh interesting -- I thought it was you who wired this up, but actually I suspect I'm mixing that up with the touch/mouse event work you did and maybe it was @LongCatIsLooong?

@cbracken cbracken added team-linux Owned by the Linux platform team and removed team-desktop labels Jun 6, 2024
@flutter-triage-bot
Copy link

The triaged-desktop label is irrelevant if there is no team-desktop label or fyi-desktop label.

@jmagman jmagman added the triaged-linux Triaged by the Linux platform team label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems P2 Important issues not at the top of the work list platform-linux Building on or for Linux specifically team-linux Owned by the Linux platform team triaged-linux Triaged by the Linux platform team
Projects
None yet
Development

No branches or pull requests

6 participants