Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in multi_widget_construction_perf__e2e_summary benchmarls #68620

Closed
kf6gpe opened this issue Oct 20, 2020 · 4 comments
Closed

Regression in multi_widget_construction_perf__e2e_summary benchmarls #68620

kf6gpe opened this issue Oct 20, 2020 · 4 comments
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks

Comments

@kf6gpe
Copy link
Contributor

kf6gpe commented Oct 20, 2020

See https://flutter-flutter-perf.skia.org/e/?begin=1602102124&end=1603169996&keys=Xa6ab3890c3982db78aadaec0616a0db6&requestType=0&xbaroffset=22068.

Was previously bimodal, with the predominant mode lower. Now it's clearly unimodal, with the higher value. Probably worth investigating, not a P0.

This affects all of
average_frame_rasterizer_time_millis90th_percentile_frame_build_time_millis, 90th_percentile_frame_rasterizer_time_millis, and average_frame_build_time_millis.

Maybe commit #68424? It started to climb on the previous commit, but that doesn't seem relevant.

@kf6gpe kf6gpe added c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. c: performance Relates to speed or footprint issues (see "perf:" labels) perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks P2 labels Oct 20, 2020
@zanderso
Copy link
Member

#67594 Looks like it could be related as well. @CareF @liyuqian

@CareF
Copy link
Contributor

CareF commented Oct 20, 2020

#67594 introduces #64780 to all macrobenchmark for consistency, including multi_widget_construction_perf__e2e_summary. That might be the reason but I don't have a local MOTO G4 to really see the time distribution to confirm.

@liyuqian
Copy link
Contributor

Confirmed that #67594 caused this regression because the added delay changed the frames that we measured and their frame time distributions. Specifically, later frames are slower to build than earlier frames as shown in the screenshot below. I'm closing this issue as there's no actual performance regression.

Screen Shot 2020-10-20 at 11 55 07 AM

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
@flutter-triage-bot flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P2 labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks
Projects
None yet
Development

No branches or pull requests

4 participants