Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[canvaskit] Cursor is shaped as a dot on canvaskit on MacOS Web #68693

Closed
TahaTesser opened this issue Oct 21, 2020 · 1 comment · Fixed by flutter/engine#22129
Closed

[canvaskit] Cursor is shaped as a dot on canvaskit on MacOS Web #68693

TahaTesser opened this issue Oct 21, 2020 · 1 comment · Fixed by flutter/engine#22129
Labels
a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now e: web_canvaskit CanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Web engine flutter/engine repository. See also e: labels. found in release: 1.24 Found to occur in 1.24 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P1 High-priority issues at the top of the work list platform-mac Building on or for macOS specifically platform-web Web applications specifically waiting for PR to land (fixed) A fix is in flight

Comments

@TahaTesser
Copy link
Member

TahaTesser commented Oct 21, 2020

Steps to reproduce

  1. Create an app on the latest master
  2. Add TextField widget
  3. execute flutter run --debug --dart-define=FLUTTER_WEB_USE_SKIA=true -d chrome

Note:
Doesn't reproduce with web HTML. Execute flutter run -d chrome

complete code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: TextField(),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

Expected Results
Cursor shape is normal

Actual Results
Cursor is shaped as a dot

Preview on the master channel

Screenshot 2020-10-21 at 3 03 20 PM

ezgif com-gif-maker

Additional context
The cursor is normal on windows when running in canvaskit, Check out #68633 (comment)

Also, the issue doesn't reproduce on the dev channel on Macos

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-2.0.pre.98, on Mac OS X 10.15.7 19H2
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-2.0.pre.98 at /Users/tahatesser/Code/flutter_master
    • Framework revision a4ac7cce82 (4 hours ago), 2020-10-21 00:46:59 -0400
    • Engine revision c2c74ed708
    • Dart version 2.11.0 (build 2.11.0-240.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.0.rc.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (5 available)
    • RMX2001 (mobile)           • EUYTFEUSQSRGDA6D                     •
      android-arm64  • Android 10 (API 29)
    • iPhone 12 Pro Max (mobile) • 1D3E6751-99F7-4E2E-B3DC-B3BEC4BB606F • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-1 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Web Server (web)           • web-server                           •
      web-javascript • Flutter Tools
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 86.0.4240.80

• No issues found!
@TahaTesser TahaTesser added a: text input Entering text in a text field or keyboard related problems e: web_canvaskit CanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Web engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. platform-mac Building on or for macOS specifically platform-web Web applications specifically c: regression It was better in the past than it is now found in release: 1.24 Found to occur in 1.24 has reproducible steps The issue has been confirmed reproducible and is ready to work on labels Oct 21, 2020
@yjbanov yjbanov added the P1 High-priority issues at the top of the work list label Oct 22, 2020
@harryterkelsen harryterkelsen added this to Open in CanvasKit issues via automation Oct 27, 2020
@harryterkelsen harryterkelsen moved this from Open to In Progress in CanvasKit issues Oct 27, 2020
@TahaTesser TahaTesser added the waiting for PR to land (fixed) A fix is in flight label Oct 28, 2020
CanvasKit issues automation moved this from In Progress to Closed Oct 29, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now e: web_canvaskit CanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Web engine flutter/engine repository. See also e: labels. found in release: 1.24 Found to occur in 1.24 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P1 High-priority issues at the top of the work list platform-mac Building on or for macOS specifically platform-web Web applications specifically waiting for PR to land (fixed) A fix is in flight
Projects
Development

Successfully merging a pull request may close this issue.

2 participants