Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material Design Color System Guidance Bug #69051

Open
feinstein opened this issue Oct 26, 2020 · 3 comments
Open

Material Design Color System Guidance Bug #69051

feinstein opened this issue Oct 26, 2020 · 3 comments
Labels
a: quality A truly polished experience f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@feinstein
Copy link
Contributor

While I was updating my App with the latest buttons and color schemes I found an inconsistency in the Material Design Specs.

Looking at the ColorScheme.light constructor, it creates a ColorScheme with 100% black text. It follows the recommendations here.

But, the recommendations here are that black text should have an opacity of 87%, which makes both specs contradict one another.

This was already reported to the Material Design Team in private messages and they confirmed it's a bug on the Color System Guidance.

I am opening this issue here so we can track the changes into the ColorScheme class to reflect the Color System Guidance fixes.

cc @willlarche
@Awaisoop
Copy link

share the code please with snap

@TahaTesser
Copy link
Member

Related #65782

@TahaTesser TahaTesser added a: quality A truly polished experience f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. passed first triage labels Oct 27, 2020
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-design Owned by Design Languages team triaged-design Triaged by Design Languages team labels Jul 8, 2023
@flutter-triage-bot flutter-triage-bot bot removed the triaged-design Triaged by Design Languages team label Jun 1, 2024
@flutter-triage-bot
Copy link

This issue is missing a priority label. Please set a priority label when adding the triaged-design label.

@Piinks Piinks added triaged-design Triaged by Design Languages team P2 Important issues not at the top of the work list labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: quality A truly polished experience f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Hixie @feinstein @Piinks @TahaTesser @Awaisoop