Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins should default to Kotlin 1.4 instead of 1.3 #70367

Closed
larssn opened this issue Nov 12, 2020 · 6 comments
Closed

Plugins should default to Kotlin 1.4 instead of 1.3 #70367

larssn opened this issue Nov 12, 2020 · 6 comments
Labels
c: proposal A detailed proposal for a change to Flutter platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@larssn
Copy link

larssn commented Nov 12, 2020

Use case

So creating a platform plugin (flutter create --org com.myorg --template=plugin --platforms=android myplugin) defaults to Kotlin 1.3.50.

Proposal

That new plugins use Kotlin 1.4, or at most, the latest version of 1.3 (1.3.72 as of writing).
But Kotlin 1.4 has a lot of neat new features and I'm not gonna list them here.

@TahaTesser TahaTesser added passed first triage platform-android Android applications specifically c: proposal A detailed proposal for a change to Flutter tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 12, 2020
@jmagman jmagman added this to Awaiting triage in Tools - plugin and package support review via automation Nov 17, 2020
@jmagman
Copy link
Member

jmagman commented Nov 17, 2020

\cc @xster Any idea what would need to be tested to do this?

@xster
Copy link
Member

xster commented Nov 18, 2020

Should revive #59037 at some point. 1.3.50 was indeed buggy. We don't have a lot of kotlin code in our repos. Most likely will be a manual test in flutter/samples.

@larssn
Copy link
Author

larssn commented Nov 18, 2020

So after raising this issue, I've been testing out v1.4.10 (because the coroutine package recommends it). It's been working great and I've not run into any problems.

@christopherfujino christopherfujino moved this from Awaiting triage to Engineer reviewed in Tools - plugin and package support review Dec 4, 2020
@stuartmorgan
Copy link
Contributor

See also #78875. Based on the issue linked from there, it seems like doing this without a migration strategy for existing apps will be problematic.

@stuartmorgan
Copy link
Contributor

This was fixed in #95383

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: proposal A detailed proposal for a change to Flutter platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Development

No branches or pull requests

5 participants