TextInputType.number deletes 2 chars at once when hitting delete #70744

joachimvalente · 2020-11-18T07:36:32Z

Internal: b/173579423

Steps to Reproduce

Run flutter create bug.
Update the files as follows:

// main.dart
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text('Test test test'),
        ),
        // TextField is also broken
        body: TextFormField(
          // .number also broken
          // but .text, .url, etc all work fine
          keyboardType: TextInputType.phone,
        ));
  }
}

flutter run
Type "12345" in the text field
Hit "delete"
=> this will delete 4 and 5 at once
Hit "delete" again
=> this will delete 2 and 3 at once

Expected results:
It should only delete one char at a time.

Actual results:
It deletes 2 chars at a time.

Logs

$ flutter run --verbose

https://gist.github.com/joachimvalente/df23aef38b4db835d132544081f6e905

$ flutter analyze
Analyzing tmptmp...                                                     
No issues found! (ran in 8.1s)

$ flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-8.0.pre.291, on Mac OS X 10.15.7 19H2 darwin-x64, locale en-US)
    • Flutter version 1.24.0-8.0.pre.291 at /Users/joachim/github/flutter
    • Framework revision c1042314a9 (37 minutes ago), 2020-11-18 01:38:02 -0500
    • Engine revision 35a0b9fe68
    • Dart version 2.12.0 (build 2.12.0-50.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/joachim/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • ANDROID_HOME = /Users/joachim/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (1 available)
    • Pixel 3 (mobile) • 89KX0AW01 • android-arm64 • Android 11 (API 30)

• No issues found!

The text was updated successfully, but these errors were encountered:

pedromassangocode · 2020-11-18T11:53:59Z

Reproducible on master and NOT in beta/stable channel.

The issue is reproducible with:

TextInputType.number
TextInputType.phone
TextInputType.datetime

Or basically any keyboardType related to numbers.

This is similar but different from #70581 because #70581 reproduces with Chinese characters only and with a text field without keyboardType.

Related to #67898.

Adding crowd because it impact lots of users.

flutter doctor -v

[✓] Flutter (Channel master, 1.24.0-8.0.pre.291, on Mac OS X 10.15.7 19H2
    darwin-x64, locale en)
    • Flutter version 1.24.0-8.0.pre.291 at
      /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision c1042314a9 (5 hours ago), 2020-11-18 01:38:02 -0500
    • Engine revision 35a0b9fe68
    • Dart version 2.12.0 (build 2.12.0-50.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 51.0.3
    • Dart plugin version 202.8070

[✓] VS Code (version 1.51.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11
      (API 30) (emulator)
    • macOS (desktop)             • macos         • darwin-x64     • Mac OS X
      10.15.7 19H2 darwin-x64
    • Web Server (web)            • web-server    • web-javascript • Flutter
      Tools
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 86.0.4240.198

• No issues found!

goderbauer · 2020-11-18T22:52:31Z

/cc @gspencergoog Didn't you recently talk about us deleting in two different places? Could this be related?

Also /cc @LongCatIsLooong @justinmc, who I think landed some changes in this area recently.

gspencergoog · 2020-11-18T23:30:49Z

Yes, I think it is related. I'll take this one.

pedromassangocode · 2020-11-19T14:00:11Z

Cc @pcsosinski

gspencergoog · 2020-11-20T00:45:49Z

I was able to see that what I suspected is true (we are handling the delete key twice now, once in the engine, once in the framework), but in fixing this, I uncovered some other race condition issues that I've been working on today.

I think can create a PR for fixing this problem, and a new bug for the race condition.

JamMarHer · 2020-11-24T15:40:13Z

I Love you people ❤️ I have been trying to figure out why this was happening to me for the past 2 hours!

JamMarHer · 2020-11-24T19:28:25Z

@pedromassangocode, @gspencergoog I have replicated a similar problem in the current flutter beta version (1.24.0-10.2.pre)

Same problem of deleting two characters at the same time

When an user types a combination of letters and numbers and then proceeds to press the delete key everything works as expected. The problem occurs when the user writes something that starts with a number and ends with a number.

This doesn't affect the web build.

Using the same code as the issue but without keyboardType :

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text('Test test test'),
        ),

        body: TextFormField());
  }
}

[✓] Flutter (Channel beta, 1.24.0-10.2.pre, on Linux, locale en_US.UTF-8)
    • Flutter version 1.24.0-10.2.pre at /home/jam/Documents/Dev/flutter
    • Framework revision 022b333a08 (6 days ago), 2020-11-18 11:35:09 -0800
    • Engine revision 07c1eed46b
    • Dart version 2.12.0 (build 2.12.0-29.10.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/jam/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /usr/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_275-8u275-b01-0ubuntu1~20.10-b01)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] Connected device (2 available)
    • SM G981U (mobile) • RFCN20S1JTJ • android-arm64  • Android 10 (API 29)
    • Web Server (web)  • web-server  • web-javascript • Flutter Tools

pedromassangocode · 2020-11-25T06:59:13Z

Hi all,
This issue was already fixed and it eventually is on master channel.

deepak786 · 2020-11-26T07:34:40Z

same issue with the dev version Flutter 1.24.0-10.2.pre • channel dev • https://github.com/flutter/flutter.git

It deletes 2 chars from the text field with InputType text as well.

Zfinix · 2020-11-27T12:13:53Z

Hi all,
This issue was already fixed and it eventually is on master channel.

Thanks!!

xihuny · 2020-12-01T18:30:32Z

Why is this closed? Is it fixed? I am on beta and still facing this issue.

gspencergoog · 2020-12-01T19:22:29Z

It was closed because it has been fixed on master. Changes on master will propagate to other branches as they proceed through the release process. See https://github.com/flutter/flutter/wiki/Flutter-build-release-channels

pcsosinski · 2020-12-03T17:20:10Z

FYI b4d4e30 will require a manual merge into flutter-1.22-candidate.12 cc @christopherfujino @gspencergoog

pcsosinski · 2020-12-10T23:17:01Z

removing cp label as this was not affecting 1.22.

jackgitsource · 2020-12-28T06:32:30Z

same issue at 1.24.0-10.2.pre • channel beta

ozc · 2021-01-13T07:20:26Z

This error also occurs for TextInputType.emailAddress

justinmc · 2021-01-14T17:47:19Z

@jackgitsource Do you see this issue on master?

jackgitsource · 2021-01-15T04:36:42Z

@justinmc No, but beta version 1.25.0-8.2 solved it

CoderJava · 2021-01-19T07:39:38Z

Yeah. In beta version 1.25.0-8.2 solved it.

pablo-johnson · 2021-02-01T21:40:30Z

Is this issue fixed on master now?

Qwampa · 2021-03-11T11:09:03Z

I am still getting this issue on Android. (stable 2.0.0)

gspencergoog · 2021-03-11T20:15:27Z

@Qwampa I'm unable to reproduce this on stable 2.0.0. If this is still happening for you, please file a new issue with all the relevant information (output of flutter doctor -v, a simple reproduction code sample, etc.).

github-actions · 2021-08-04T17:08:54Z

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

pedromassangocode changed the title ~~TextFormField with phone input deletes 2 chars at once when hitting delete~~ TextInputType.number deletes 2 chars at once when hitting delete Nov 18, 2020

gspencergoog self-assigned this Nov 18, 2020

gspencergoog added P2 Important issues not at the top of the work list P1 High-priority issues at the top of the work list and removed P2 Important issues not at the top of the work list labels Nov 18, 2020

yash1200 mentioned this issue Nov 19, 2020

TextField will delete two characters at a time if input type is phone #70854

Closed

mehmetf added P1 customer: money (g3) and removed P1 High-priority issues at the top of the work list labels Nov 19, 2020

gspencergoog mentioned this issue Nov 20, 2020

Fix double delete on backspace on Android flutter/engine#22626

Merged

1 task

fluttergithubbot closed this as completed in flutter/engine#22626 Nov 20, 2020

gspencergoog mentioned this issue Nov 20, 2020

[TextField] backspace key removes two characters at a time in Chinese, which is not a problem in the English letters #70581

Closed

christopherfujino mentioned this issue Nov 23, 2020

backspace button works twice at physical Android device #71101

Closed

This comment was marked as abuse.

Sign in to view

LongCatIsLooong mentioned this issue Dec 1, 2020

TextFormField backspace delete 2 characters at a time #71404

Closed

HansMuller added the cp: 1.22 label Dec 1, 2020

pcsosinski modified the milestone: 1.26 - December 2020 Dec 10, 2020

pcsosinski removed the cp: 1.22 label Dec 10, 2020

gspencergoog mentioned this issue Dec 16, 2020

the Backspace key always delete two characters when I use this TextField Widget. #72437

Closed

JELaVallee mentioned this issue Mar 31, 2021

Backspace not working on Android #78769

Closed

alinpahontu2912 mentioned this issue Jul 28, 2021

Passwords fields are sensitive to character deletions student-hub/acs-upb-mobile#147

Open

github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021

flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P1 labels Jun 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TextInputType.number deletes 2 chars at once when hitting delete #70744

TextInputType.number deletes 2 chars at once when hitting delete #70744

joachimvalente commented Nov 18, 2020 •

edited by mehmetf

pedromassangocode commented Nov 18, 2020 •

edited

goderbauer commented Nov 18, 2020

gspencergoog commented Nov 18, 2020

pedromassangocode commented Nov 19, 2020

gspencergoog commented Nov 20, 2020

JamMarHer commented Nov 24, 2020

JamMarHer commented Nov 24, 2020 •

edited

pedromassangocode commented Nov 25, 2020

deepak786 commented Nov 26, 2020 •

edited

Zfinix commented Nov 27, 2020

This comment was marked as abuse.

xihuny commented Dec 1, 2020 •

edited

gspencergoog commented Dec 1, 2020

pcsosinski commented Dec 3, 2020

pcsosinski commented Dec 10, 2020

jackgitsource commented Dec 28, 2020

ozc commented Jan 13, 2021

justinmc commented Jan 14, 2021

jackgitsource commented Jan 15, 2021

CoderJava commented Jan 19, 2021

pablo-johnson commented Feb 1, 2021

Qwampa commented Mar 11, 2021

gspencergoog commented Mar 11, 2021

github-actions bot commented Aug 4, 2021

TextInputType.number deletes 2 chars at once when hitting delete #70744

TextInputType.number deletes 2 chars at once when hitting delete #70744

Comments

joachimvalente commented Nov 18, 2020 • edited by mehmetf

Steps to Reproduce

pedromassangocode commented Nov 18, 2020 • edited

goderbauer commented Nov 18, 2020

gspencergoog commented Nov 18, 2020

pedromassangocode commented Nov 19, 2020

gspencergoog commented Nov 20, 2020

JamMarHer commented Nov 24, 2020

JamMarHer commented Nov 24, 2020 • edited

pedromassangocode commented Nov 25, 2020

deepak786 commented Nov 26, 2020 • edited

Zfinix commented Nov 27, 2020

This comment was marked as abuse.

xihuny commented Dec 1, 2020 • edited

gspencergoog commented Dec 1, 2020

pcsosinski commented Dec 3, 2020

pcsosinski commented Dec 10, 2020

jackgitsource commented Dec 28, 2020

ozc commented Jan 13, 2021

justinmc commented Jan 14, 2021

jackgitsource commented Jan 15, 2021

CoderJava commented Jan 19, 2021

pablo-johnson commented Feb 1, 2021

Qwampa commented Mar 11, 2021

gspencergoog commented Mar 11, 2021

github-actions bot commented Aug 4, 2021

joachimvalente commented Nov 18, 2020 •

edited by mehmetf

pedromassangocode commented Nov 18, 2020 •

edited

JamMarHer commented Nov 24, 2020 •

edited

deepak786 commented Nov 26, 2020 •

edited

xihuny commented Dec 1, 2020 •

edited