Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrong exitCode in gradle task #74479

Closed
voiddog opened this issue Jan 22, 2021 · 5 comments · Fixed by #71582
Closed

Use wrong exitCode in gradle task #74479

voiddog opened this issue Jan 22, 2021 · 5 comments · Fixed by #71582
Labels
in triage Presently being triaged by the triage team

Comments

@voiddog
Copy link

voiddog commented Jan 22, 2021

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle.dart#L680

 if (result.exitCode != 0) {
    globals.printStatus(result.stdout, wrap: false);
    globals.printError(result.stderr, wrap: false);
    throwToolExit(
      'Gradle task $aarTask failed with exit code $exitCode.',
      exitCode: exitCode,
    );
  }

The exitCode here should use result.exitCode otherwise will occur Gradle task assembleAarDebug failed with exit code 0.(The script will judge it as successful)

@darshankawar
Copy link
Member

@voiddog
Do you have a use case wherein the above will result in Gradle task assembleAarDebug failed with exit code 0 ?
Can you provide steps to replicate that will throw this error ?

@darshankawar darshankawar added in triage Presently being triaged by the triage team waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds labels Jan 22, 2021
@voiddog
Copy link
Author

voiddog commented Jan 22, 2021

Yes, I can create a reproducible demo
Wait a while... I will @ you after I'm done

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 22, 2021
@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 22, 2021
@MrBirb
Copy link
Contributor

MrBirb commented Jan 22, 2021

@pedromassango Duplicate of #71484

@pedromassango
Copy link
Member

They are similar,seems that someone found it in this PR #71582 (comment). This will be fixed by #71582 as well.

@pedromassangocode pedromassangocode removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Feb 26, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in triage Presently being triaged by the triage team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants