New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the unit of file size from "kb" (maybe "kilo bits") to "KB" #76033
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like this is failing some tests, though. Can you please fix those?
@goderbauer Thanks! I only change 2 characters in a literal String, so I am a bit confused why it the tests are failed... I have looked at the CI logs, but seems no clues (since I am not very familiar with all the infrastructures of Flutter). Could you please give some hints? |
There appear to be tests that verify the error message you're modifying. You can probably reproduce this locally by going into the |
@goderbauer Thanks! I will have a look |
@goderbauer Hi all checks have passed! |
Wait a bit... The flutter-build fails? Hours ago it was all green... Is that related to my PR or not? When I click "Details" I see a dashboard, which seems to have no relationship to me... |
The error message when enabling "invert oversized images" tells us how many extra space the image uses. That is quite helpful! However, when I read
...an additional 1234kb...
I thought that means kilo bits (since in network programmingkb
andkB
are definitely different and should be taken with care). However, after reading the source code, I suddenly realized that it is kilo bytes. Thus, this PR is here to ensure that people do not misunderstand the unit.List which issues are fixed by this PR. You must list at least one issue.
Fixes #76032
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
N/A
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.