Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the unit of file size from "kb" (maybe "kilo bits") to "KB" #76033

Merged
merged 2 commits into from Feb 18, 2021

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Feb 15, 2021

The error message when enabling "invert oversized images" tells us how many extra space the image uses. That is quite helpful! However, when I read ...an additional 1234kb...I thought that means kilo bits (since in network programming kb and kB are definitely different and should be taken with care). However, after reading the source code, I suddenly realized that it is kilo bytes. Thus, this PR is here to ensure that people do not misunderstand the unit.

List which issues are fixed by this PR. You must list at least one issue.
Fixes #76032

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
N/A

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 15, 2021
@google-cla google-cla bot added the cla: yes label Feb 15, 2021
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like this is failing some tests, though. Can you please fix those?

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Feb 18, 2021

@goderbauer Thanks! I only change 2 characters in a literal String, so I am a bit confused why it the tests are failed... I have looked at the CI logs, but seems no clues (since I am not very familiar with all the infrastructures of Flutter). Could you please give some hints?

@goderbauer
Copy link
Member

There appear to be tests that verify the error message you're modifying. You can probably reproduce this locally by going into the packages/flutter directory and running flutter test there.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Feb 18, 2021

@goderbauer Thanks! I will have a look

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Feb 18, 2021

@goderbauer Hi all checks have passed!

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Feb 18, 2021

Wait a bit... The flutter-build fails? Hours ago it was all green...

Is that related to my PR or not? When I click "Details" I see a dashboard, which seems to have no relationship to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The unit of file size is "kb" but actually it means "kilo bytes" not "kilo bits"
3 participants