-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssetImage docs improvements #78088
Comments
It can probably just point to ImageProvider, which has a "Using an ImageProvider" section. |
I would like to work on this issue. Can I please be assigned to this? |
@Swayam221 No need to be assigned, just submit a PR! Thanks, looking forward to it! |
So, should I just include a link to the docs for ImageProvider there? |
Well you'd want to make the text flow nicely, and so on. I haven't looked at exactly what would need to happen, if I had, I would just make the change directly. :-) Figuring out what the change should be is 90% of the work. |
@Hixie I think if we point it to this link https://flutter.dev/docs/development/ui/assets-and-images#loading-images-1 , it will be well understandable. |
I recommend starting with the contributing docs: |
@mateusfccp what do you exactly mean by 'fix some instances of AssetImage' ? |
As it shows in the image I provided, there are some samples on the |
@mateusfccp Oh yes, I see. Should I change this as well, @Hixie ? |
Let's keep each individual issue separate for now, it becomes more complicated when things are mixed. Separate bug, separate PR, etc. |
@Hixie I see, I am going to open a separate PR, then. Is it a must to create an issue too? |
It's ideal to have one issue per PR and one PR per issue at least until you are an experienced contributor. :-) |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
AssetImage docs has a "Fetching assets" section but that section doesn't actually tell you how to fetch an asset, it just tells you how to specify a name when you're not in a package.
We should have a section that talks about how to actually fetch an asset (i.e. how to use the class).
The text was updated successfully, but these errors were encountered: