Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests on Windows #8003

Closed
goderbauer opened this issue Feb 8, 2017 · 6 comments
Closed

Run all tests on Windows #8003

goderbauer opened this issue Feb 8, 2017 · 6 comments
Labels
platform-windows Building on or for Windows specifically

Comments

@goderbauer
Copy link
Member

Currently, we are skipping some tests on the Windows platform because they are hitting features that are not yet implemented on Windows.

Filing this issue as a placeholder to make sure we enable those tests when we are ready on Windows.

To find them, just search for skip: Platform.isWindows or skip: io.Platform.isWindows in the code base.

@goderbauer goderbauer added the platform-windows Building on or for Windows specifically label Feb 8, 2017
@goderbauer
Copy link
Member Author

We also need to run these tests on the Chromebots, which is currently blocked by not having Java on the Windows bots.

@goderbauer
Copy link
Member Author

Quick update:

  • All tests except for those requiring sky_snapshot or sky_shell are now run-able on Windows.
  • We run our test suite on Windows via appveyor for every PR (runs same set of tests as Travis).
  • The Linux, Windows, and Mac Chromebots now all do the same thing (run test suite and build example apps).

The only thing left to do for this issue: Enable tests requiring sky_shell or sky_snapshot on Windows once those two are available for the platform.

@Hixie Hixie added this to the No milestone necessary milestone Feb 28, 2017
@goderbauer
Copy link
Member Author

After #8512 has been submitted, the only remaining tests not running on Windows are those requiring sky_shell. We are getting pretty close to parity with Linux/Mac on the testing front!

@goderbauer
Copy link
Member Author

Further work on this is blocked by #8516.

@goderbauer
Copy link
Member Author

This has been done.

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-windows Building on or for Windows specifically
Projects
None yet
Development

No branches or pull requests

2 participants