Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hsl adjustment specifically for 6 different colors #80820

Open
gulmensedat opened this issue Apr 20, 2021 · 11 comments
Open

Hsl adjustment specifically for 6 different colors #80820

gulmensedat opened this issue Apr 20, 2021 · 11 comments
Labels
a: images Loading, displaying, rendering images c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team would be a good package Separate Flutter package should be made for this

Comments

@gulmensedat
Copy link

I want to provide specific hue, saturation, lightness adjustment for 6 different color tones in a photo. I couldn't do this in flutter. For one color, it is partially done with the ColorFiltered matrix method, but I could not do it for 6 different shades at the same time.
If I could not explain, I want to give an example:
Let's say red, orange, yellow colors on a photo.
I just want to adjust the saturation value of the area with red tint, I want to be able to adjust the orange and yellow separately.

This hsl feature works very well in applications such as lightroom, vsco. I could not do it in Flutter, I looked at the examples and libraries and saw that it was insufficient. I asked the Flutter developers for support and they couldn't figure it out, so I wanted to post here. I want help how can I solve this issue.

@bdlukaa
Copy link

bdlukaa commented Apr 20, 2021

What do you want exactly? You can manipulate hsl colors by caliing HSLColor.fromColor(color). I think you can add mutiple ColorFiltered to a tree, each one with a different shade.

@gulmensedat
Copy link
Author

What do you want exactly? You can manipulate hsl colors by caliing HSLColor.fromColor(color). I think you can add mutiple ColorFiltered to a tree, each one with a different shade.

This is the method I am using now, but the colors are mixed together, this time I tried it in the form of a stack or a tree, the result is the same colors are mixed. That is the way with the matrix. With hsl color, it affects the whole image, so it is not specific.

@darshankawar darshankawar added the in triage Presently being triaged by the triage team label Apr 21, 2021
@darshankawar
Copy link
Member

@gulmensedat
Check if this issue correctly represents your case, #76729
If so, you may follow-up in it for updates.

@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 21, 2021
@gulmensedat
Copy link
Author

@gulmensedat
Check if this issue correctly represents your case, #76729
If so, you may follow-up in it for updates.

Unfortunately it doesn't work for me.

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 21, 2021
@darshankawar
Copy link
Member

@gulmensedat
It'll be great if you could provide us a code example that shows current limitation and what would you like to add to make it work as expected per your requirement.
Thanks.

@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 22, 2021
@gulmensedat
Copy link
Author

@gulmensedat
It'll be great if you could provide us a code example that shows current limitation and what would you like to add to make it work as expected per your requirement.
Thanks.

https://www.youtube.com/watch?v=rLQ6q_yb1aE

I recorded a screen video from a sample application because I could not yet provide this feature that I wanted to improve with the codes as I wanted. The photo in the video has the colors Red, Orange and Yellow. Specifically, the hsl can be adjusted on the basis of color, as you can see in the video. And I don't think it's an asynchronous operation. I need a widget that works very well like ColorFiltered, I need to be able to make this setting instantly, I don't want to process the image with the image library. What should I do about it?

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label May 3, 2021
@darshankawar
Copy link
Member

@gulmensedat
Can you try this plugin and see if it suits your requirement ? https://pub.dev/packages/hsluv

@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label May 3, 2021
@gulmensedat
Copy link
Author

@gulmensedat
Can you try this plugin and see if it suits your requirement ? https://pub.dev/packages/hsluv

Unfortunately, this plugin does not work for me because it provides interface-oriented color change, that is, it provides color adjustment for a normal Color, but I have to make this adjustment on the photo, so I have to change the color only for the parts of the photo that have the color I choose. I sent an e-mail to the developer friend who wrote the library you specified and stated that this plugin is not suitable for photos and that it is interface oriented. He could not help me either.

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label May 3, 2021
@darshankawar
Copy link
Member

Treating this as feature request for images.

@darshankawar darshankawar added framework flutter/packages/flutter repository. See also f: labels. c: proposal A detailed proposal for a change to Flutter c: new feature Nothing broken; request for a new capability would be a good package Separate Flutter package should be made for this a: images Loading, displaying, rendering images passed first triage and removed in triage Presently being triaged by the triage team labels May 4, 2021
@gulmensedat
Copy link
Author

gulmensedat commented May 5, 2021

There is actually a resource written in Swift, but I don't know how I can use it efficiently with flutter.
https://dzone.com/articles/creating-a-selective-hsl-adjustment-filter-in-core

@darshankawar

@goderbauer
Copy link
Member

This sounds like it could just be implemented in a package.

@goderbauer goderbauer added the P6 label May 4, 2022
@flutter-triage-bot flutter-triage-bot bot added P3 Issues that are less important to the Flutter project and removed P6 labels Jun 28, 2023
@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: images Loading, displaying, rendering images c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team would be a good package Separate Flutter package should be made for this
Projects
None yet
Development

No branches or pull requests

5 participants